Skip to content

fix: prevent floating compare bar DOM accumulation on repeated toggle(#225) #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jagdish-15 merged 1 commit into from
Jun 21, 2026
+16 −14
Merged

fix: prevent floating compare bar DOM accumulation on repeated toggle(#225) #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions frontend/js/leaderboard/compare.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,14 +203,29 @@ function updateFloatingCompareBar() {
let bar = document.getElementById("floating-compare-bar");

if (window.selectedUsers.length === 0) {
if (bar) bar.style.display = "none";
if (bar) bar.remove();
return;
}

if (!bar) {
bar = document.createElement("div");
bar.id = "floating-compare-bar";
bar.className = "floating-compare-bar";
// Event delegation: single listener handles all button clicks
bar.addEventListener("click", (e) => {
const btn = e.target.closest("button");
if (!btn) return;
if (btn.id === "floating-btn-clear") {
clearSelectedUsers();
} else if (btn.id === "floating-btn-cancel") {
toggleCompareMode();
} else if (
btn.id === "floating-btn-compare" &&
window.selectedUsers.length >= 2
) {
openCompareModal();
}
});
document.body.appendChild(bar);
}

Expand All @@ -229,19 +244,6 @@ function updateFloatingCompareBar() {
<button id="floating-btn-cancel" class="btn-clear" style="color: var(--amber);">Cancel</button>
</div>
`;

// Bind click handlers
document
.getElementById("floating-btn-clear")
.addEventListener("click", clearSelectedUsers);
document
.getElementById("floating-btn-cancel")
.addEventListener("click", toggleCompareMode);
if (count >= 2) {
document
.getElementById("floating-btn-compare")
.addEventListener("click", openCompareModal);
}
}

/**
Expand Down
Loading