Skip to content

Feature: the icons are added#91

Closed
sharonchelsy30 wants to merge 2 commits into
codepvg:mainfrom
sharonchelsy30:footer
Closed

Feature: the icons are added#91
sharonchelsy30 wants to merge 2 commits into
codepvg:mainfrom
sharonchelsy30:footer

Conversation

@sharonchelsy30

@sharonchelsy30 sharonchelsy30 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Hi, @jagdish-15
closes #85

Added social media icons to the footer links to improve visual appearance and make navigation to CodePVG's social platforms more intuitive.

  • Added GitHub icon before the GitHub footer link.
  • Added LinkedIn icon before the LinkedIn footer link.
  • Added YouTube icon before the YouTube footer link.
  • Added WhatsApp icon before the WhatsApp footer link.
  • Updated footer styling to properly align icons with link text.
image

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for submitting a pull request.

Please ensure your changes comply with the project's contribution guidelines and that all workflow checks pass successfully.

A maintainer will review your submission shortly.

@jagdish-15 jagdish-15 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit the changes suggested, and we should be ready to merge this

Comment thread frontend/js/footer.js
@@ -1 +1 @@
document.addEventListener("DOMContentLoaded", () => {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!document.querySelector('link[data-font-awesome]')) {
const iconStylesheet = document.createElement("link");
iconStylesheet.rel = "stylesheet";
iconStylesheet.href =
"https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.5.2/css/all.min.css";
iconStylesheet.setAttribute("data-font-awesome", "true");
document.head.appendChild(iconStylesheet);
}
document.addEventListener("DOMContentLoaded", () => {

Adding this will dynamically load the stylesheet on any page that uses the shared footer component

Comment thread frontend/leaderboard.html
Comment on lines +15 to +18
<link
rel="stylesheet"
href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.5.2/css/all.min.css"
/>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<link
rel="stylesheet"
href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.5.2/css/all.min.css"
/>

Since footer.js is used across all pages except the home page, adding the Font Awesome stylesheet only to leaderboard.html won't make the icons available on the other pages using the shared footer component.

A better approach would be to load the stylesheet dynamically from the footer.js file itself, so we can remove the direct stylesheet import from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: To add icons

2 participants