Skip to content

Feature: the icons are added #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sharonchelsy30 wants to merge 2 commits into from
Closed

Feature: the icons are added #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd3ee02
the icons are added
sharonchelsy30 Jun 3, 2026
dc39ec7
fix prettier formatting
sharonchelsy30 Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 27 additions & 8 deletions frontend/js/footer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,33 @@ document.addEventListener("DOMContentLoaded", () => {
</div>

<div class="footer-section">
<h3>socials</h3>
<ul>
<li><a href="https://github.com/codepvg/" target="_blank">github</a></li>
<li><a href="https://www.linkedin.com/company/codepvg/" target="_blank">linkedin</a></li>
<li><a href="https://www.youtube.com/@codepvg529" target="_blank">youtube</a></li>
<li><a href="https://chat.whatsapp.com/E5INVk1UJX6KL5oZK0wPAQ?mode=gi_t" target="_blank">whatsapp</a></li>
</ul>
</div>
<h3>socials</h3>
<ul>
<li>
<a href="https://github.com/codepvg/" target="_blank">
<i class="fab fa-github"></i> github
</a>
</li>

<li>
<a href="https://www.linkedin.com/company/codepvg/" target="_blank">
<i class="fab fa-linkedin"></i> linkedin
</a>
</li>

<li>
<a href="https://www.youtube.com/@codepvg529" target="_blank">
<i class="fab fa-youtube"></i> youtube
</a>
</li>

<li>
<a href="https://chat.whatsapp.com/E5INVk1UJX6KL5oZK0wPAQ?mode=gi_t" target="_blank">
<i class="fab fa-whatsapp"></i> whatsapp
</a>
</li>
</ul>
</div>

<div class="footer-section">
<h3>contact</h3>
Expand Down
4 changes: 4 additions & 0 deletions frontend/leaderboard.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
/>
<link rel="stylesheet" href="styles/main.css" />
<link rel="icon" type="image/png" href="assets/logo.png" />
<link
rel="stylesheet"
href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.5.2/css/all.min.css"
/>
Comment on lines +15 to +18

@jagdish-15 jagdish-15 Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<link
rel="stylesheet"
href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.5.2/css/all.min.css"
/>

Since footer.js is used across all pages except the home page, adding the Font Awesome stylesheet only to leaderboard.html won't make the icons available on the other pages using the shared footer component.

A better approach would be to load the stylesheet dynamically from the footer.js file itself, so we can remove the direct stylesheet import from here.

<script src="js/navbar.js"></script>
</head>

Expand Down