Skip to content

Commit 2c5b286

Browse files
committed
fixup! refactor: inline readiness check, close errCh, drain queue on cancel
1 parent 2b64027 commit 2c5b286

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

lib/screentracker/pty_conversation.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ func (c *PTYConversation) Start(ctx context.Context) {
181181
case msg := <-c.outboundQueue:
182182
if msg.errCh != nil {
183183
msg.errCh <- ctx.Err()
184-
close(msg.errCh)
184+
close(msg.errCh) // help GC
185185
}
186186
default:
187187
return
@@ -200,7 +200,7 @@ func (c *PTYConversation) Start(ctx context.Context) {
200200
err := c.sendMessage(ctx, msg.parts...)
201201
if msg.errCh != nil {
202202
msg.errCh <- err
203-
close(msg.errCh)
203+
close(msg.errCh) // help GC
204204
}
205205
default:
206206
c.cfg.Logger.Error("received stable signal but outbound queue is empty")

0 commit comments

Comments
 (0)