fix(chat): stop clearing messages on SSE reconnect

Messages were reset to [] every time the EventSource reconnected,
including on transient network errors. This blanked the entire
conversation. Now we let the browser handle SSE reconnection
natively and never clear the message list.

Also removes the draft filter in sendMessage's finally block which
caused the user's message to briefly disappear before the server
confirmed it. Drafts are now replaced inline when the matching
confirmed message arrives via SSE.

Author: mafredri

chat/src/components/chat-provider.tsx

@@ -141,112 +141,80 @@ export function ChatProvider({ children }: PropsWithChildren) {
   const eventSourceRef = useRef<EventSource | null>(null);
   const agentAPIUrl = useAgentAPIUrl();
 
-  // Set up SSE connection to the events endpoint
+  // Set up SSE connection to the events endpoint. EventSource handles
+  // reconnection automatically, so we only create it once per URL and
+  // let the browser manage transient failures. Messages are NOT cleared
+  // on reconnect to avoid blanking the conversation on network blips.
   useEffect(() => {
-    // Function to create and set up EventSource
-    const setupEventSource = () => {
-      if (eventSourceRef.current) {
-        eventSourceRef.current.close();
-      }
+    if (!agentAPIUrl) {
+      console.warn(
+        "agentAPIUrl is not set, SSE connection cannot be established."
+      );
+      setServerStatus("offline");
+      return;
+    }
 
-      // Reset messages when establishing a new connection
-      setMessages([]);
+    const eventSource = new EventSource(`${agentAPIUrl}/events`);
+    eventSourceRef.current = eventSource;
 
-      if (!agentAPIUrl) {
-        console.warn(
-          "agentAPIUrl is not set, SSE connection cannot be established."
+    // Handle message updates
+    eventSource.addEventListener("message_update", (event) => {
+      const data: MessageUpdateEvent = JSON.parse(event.data);
+      const confirmed: Message = {
+        role: data.role,
+        content: data.message,
+        id: data.id,
+      };
+
+      setMessages((prevMessages) => {
+        // Check if message with this ID already exists
+        const existingIndex = prevMessages.findIndex(
+          (m) => m.id === data.id
         );
-        setServerStatus("offline"); // Or some other appropriate status
-        return null; // Don't try to connect if URL is empty
-      }
 
-      const eventSource = new EventSource(`${agentAPIUrl}/events`);
-      eventSourceRef.current = eventSource;
-
-      // Handle message updates
-      eventSource.addEventListener("message_update", (event) => {
-        const data: MessageUpdateEvent = JSON.parse(event.data);
-
-        setMessages((prevMessages) => {
-          // Clean up draft messages
-          const updatedMessages = [...prevMessages].filter(
-            (m) => !isDraftMessage(m)
-          );
-
-          // Check if message with this ID already exists
-          const existingIndex = updatedMessages.findIndex(
-            (m) => m.id === data.id
-          );
-
-          if (existingIndex !== -1) {
-            // Update existing message
-            updatedMessages[existingIndex] = {
-              role: data.role,
-              content: data.message,
-              id: data.id,
-            };
-            return updatedMessages;
-          } else {
-            // Add new message
-            return [
-              ...updatedMessages,
-              {
-                role: data.role,
-                content: data.message,
-                id: data.id,
-              },
-            ];
-          }
-        });
-      });
+        if (existingIndex !== -1) {
+          // Update in place without copying the whole array prefix/suffix.
+          const updated = [...prevMessages];
+          updated[existingIndex] = confirmed;
+          return updated;
+        }
 
-      // Handle status changes
-      eventSource.addEventListener("status_change", (event) => {
-        const data: StatusChangeEvent = JSON.parse(event.data);
-        if (data.status === "stable") {
-          setServerStatus("stable");
-        } else if (data.status === "running") {
-          setServerStatus("running");
-        } else {
-          setServerStatus("unknown");
+        // New confirmed message: replace any trailing draft that matches
+        // the same role (the optimistic message we inserted on send).
+        const last = prevMessages[prevMessages.length - 1];
+        if (last && isDraftMessage(last) && last.role === confirmed.role) {
+          return [...prevMessages.slice(0, -1), confirmed];
         }
 
-        // Set agent type
-        setAgentType(data.agent_type === "" ? "unknown" : data.agent_type as AgentType);
+        return [...prevMessages, confirmed];
       });
+    });
+
+    // Handle status changes
+    eventSource.addEventListener("status_change", (event) => {
+      const data: StatusChangeEvent = JSON.parse(event.data);
+      if (data.status === "stable") {
+        setServerStatus("stable");
+      } else if (data.status === "running") {
+        setServerStatus("running");
+      } else {
+        setServerStatus("unknown");
+      }
+      setAgentType(data.agent_type === "" ? "unknown" : data.agent_type as AgentType);
+    });
 
-      // Handle connection open (server is online)
-      eventSource.onopen = () => {
-        // Connection is established, but we'll wait for status_change event
-        // for the actual server status
-        console.log("EventSource connection established - messages reset");
-      };
-
-      // Handle connection errors
-      eventSource.onerror = (error) => {
-        console.error("EventSource error:", error);
-        setServerStatus("offline");
-
-        // Try to reconnect after delay
-        setTimeout(() => {
-          if (eventSourceRef.current) {
-            setupEventSource();
-          }
-        }, 3000);
-      };
-
-      return eventSource;
+    eventSource.onopen = () => {
+      console.log("EventSource connection established");
     };
 
-    // Initial setup
-    const eventSource = setupEventSource();
+    // Mark offline on error. The browser will retry automatically.
+    eventSource.onerror = () => {
+      setServerStatus("offline");
+    };
 
-    // Clean up on component unmount
     return () => {
-      if (eventSource) {
-        // Check if eventSource was successfully created
-        eventSource.close();
-      }
+      eventSource.close();
+      eventSourceRef.current = null;
     };
   }, [agentAPIUrl]);
 
@@ -304,9 +272,6 @@ export function ChatProvider({ children }: PropsWithChildren) {
       });
     } finally {
       if (type === "user") {
-        setMessages((prevMessages) =>
-          prevMessages.filter((m) => !isDraftMessage(m))
-        );
         setLoading(false);
       }
     }

chat/src/components/message-list.tsx

@@ -67,12 +67,17 @@ export default function MessageList({messages}: MessageListProps) {
   }, [checkIfAtBottom, scrollAreaRef]);
 
   // Pin to bottom when new content arrives, but only if the user hasn't
-  // scrolled away. Direct scrollTop assignment is synchronous and avoids
-  // the animation conflicts that smooth scrollTo causes during streaming.
+  // scrolled away. Always scroll when the latest message is from the user
+  // (they just sent it and should see it). Direct scrollTop assignment is
+  // synchronous and avoids the animation conflicts that smooth scrollTo
+  // causes during streaming.
   useLayoutEffect(() => {
     if (!scrollAreaRef) return;
-    if (!isAtBottomRef.current) return;
+    const lastMessage = messages[messages.length - 1];
+    const isUserMessage = lastMessage && lastMessage.role === "user";
+    if (!isAtBottomRef.current && !isUserMessage) return;
     scrollAreaRef.scrollTop = scrollAreaRef.scrollHeight;
+    isAtBottomRef.current = true;
   }, [messages, scrollAreaRef]);
 
   // If no messages, show a placeholder