Skip to content

Commit 38f119d

Browse files
committed
Simplify assertMessages to use require.Equal instead of per-field loop
1 parent a5edc13 commit 38f119d

1 file changed

Lines changed: 4 additions & 10 deletions

File tree

lib/screentracker/pty_conversation_test.go

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -95,17 +95,11 @@ func sendWithClockDrive(ctx context.Context, t *testing.T, c *st.PTYConversation
9595
func assertMessages(t *testing.T, c *st.PTYConversation, expected []st.ConversationMessage) {
9696
t.Helper()
9797
actual := c.Messages()
98-
require.Len(t, actual, len(expected))
99-
for i := range expected {
100-
assert.Equal(t, expected[i].Id, actual[i].Id, "message %d Id", i)
101-
assert.Equal(t, expected[i].Message, actual[i].Message, "message %d Message", i)
102-
assert.Equal(t, expected[i].Role, actual[i].Role, "message %d Role", i)
103-
if expected[i].Time.IsZero() {
104-
assert.False(t, actual[i].Time.IsZero(), "message %d Time should be non-zero", i)
105-
} else {
106-
assert.Equal(t, expected[i].Time, actual[i].Time, "message %d Time", i)
107-
}
98+
for i := range actual {
99+
require.False(t, actual[i].Time.IsZero(), "message %d Time should be non-zero", i)
100+
actual[i].Time = time.Time{}
108101
}
102+
require.Equal(t, expected, actual)
109103
}
110104

111105
type statusTestStep struct {

0 commit comments

Comments
 (0)