refactor: move draft cleanup to finally block in sendMessage

Author: johnstcn

chat/src/components/chat-provider.tsx

@@ -280,7 +280,6 @@ export function ChatProvider({ children }: PropsWithChildren) {
       });
 
       if (!response.ok) {
-        setMessages((prev) => prev.filter((m) => !isDraftMessage(m)));
         const errorData = await response.json() as APIErrorModel;
         console.error("Failed to send message:", errorData);
         const detail = errorData.detail;
@@ -297,14 +296,15 @@ export function ChatProvider({ children }: PropsWithChildren) {
       }
 
     } catch (error) {
-      setMessages((prev) => prev.filter((m) => !isDraftMessage(m)));
       console.error("Error sending message:", error);
       const message = getErrorMessage(error)
 
       toast.error(`Error sending message`, {
         description: message,
       });
     } finally {
+      // Remove optimistic draft message if still present (may have been replaced by server response via SSE).
+      setMessages((prev) => prev.filter((m) => !isDraftMessage(m)));
       if (type === "user") {
         setLoading(false);
       }