Skip to content

Commit 089e24d

Browse files
committed
add no prompt recording check to TestClientAndConnectionError test
1 parent 35df6d8 commit 089e24d

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

responses_integration_test.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ func TestResponsesOutputMatchesUpstream(t *testing.T) {
128128
t.Cleanup(mockAPI.Close)
129129

130130
provider := provider.NewOpenAI(openaiCfg(mockAPI.URL, apiKey))
131-
srv, rec := newTestSrv(t, ctx, provider, nil, testTracer)
131+
srv, mockRecorder := newTestSrv(t, ctx, provider, nil, testTracer)
132132
defer srv.Close()
133133

134134
req := createOpenAIResponsesReq(t, srv.URL, files[fixtureRequest])
@@ -144,11 +144,11 @@ func TestResponsesOutputMatchesUpstream(t *testing.T) {
144144
require.Equal(t, string(files[fixtResp]), string(got))
145145

146146
if tc.expectPromptRecorded != "" {
147-
recordedPrompts := rec.RecordedPromptUsages()
147+
recordedPrompts := mockRecorder.RecordedPromptUsages()
148148
promptEq := func(pur *recorder.PromptUsageRecord) bool { return pur.Prompt == tc.expectPromptRecorded }
149149
require.Truef(t, slices.ContainsFunc(recordedPrompts, promptEq), "promnt not found, got: %v, want: %v", recordedPrompts, tc.expectPromptRecorded)
150150
} else {
151-
require.Empty(t, rec.RecordedPromptUsages())
151+
require.Empty(t, mockRecorder.RecordedPromptUsages())
152152
}
153153
})
154154
}
@@ -359,7 +359,7 @@ func TestClientAndConnectionError(t *testing.T) {
359359
t.Cleanup(cancel)
360360

361361
prov := provider.NewOpenAI(openaiCfg(tc.addr, apiKey))
362-
srv, _ := newTestSrv(t, ctx, prov, nil, testTracer)
362+
srv, mockRecorder := newTestSrv(t, ctx, prov, nil, testTracer)
363363
defer srv.Close()
364364

365365
reqBytes := responsesRequestBytes(t, tc.streaming)
@@ -376,6 +376,8 @@ func TestClientAndConnectionError(t *testing.T) {
376376
body, err := io.ReadAll(resp.Body)
377377
require.NoError(t, err)
378378
require.Contains(t, string(body), tc.errContains)
379+
380+
require.Empty(t, mockRecorder.RecordedPromptUsages())
379381
})
380382
}
381383
}

0 commit comments

Comments
 (0)