chore: lint fixes part 6#258
Merged
Merged
Conversation
This was referenced Apr 10, 2026
Contributor
Author
This was referenced Apr 10, 2026
| // Methods provide package-specific reads and rewrites while preserving the | ||
| // original body for upstream pass-through. | ||
| type MessagesRequestPayload []byte | ||
| type RequestPayload []byte |
Collaborator
There was a problem hiding this comment.
This is kind of at odds with #257 where errorResponse became chatCompletionResponseError.
Let's pick one approach and use it consistently.
Contributor
Author
There was a problem hiding this comment.
Thanks, good catch. There are 2 different rules:
- errname: error types need to have Error suffix
- exported stutter: exported symbols cannot start with package name
RequestPayload types are exported so it is enforced while error types from #257 are internal.
I'll update #257 to match stutter rule even thou error types are not exported.
pawbana
force-pushed
the
pb/coder-lint-fix6
branch
from
95d767c to
523ed94
Compare
pawbana
force-pushed
the
pb/coder-lint-fix5
branch
from
31f8bd5 to
240e79c
Compare
pawbana
force-pushed
the
pb/coder-lint-fix6
branch
from
523ed94 to
6139b9e
Compare
pawbana
force-pushed
the
pb/coder-lint-fix5
branch
from
240e79c to
02b6daf
Compare
pawbana
force-pushed
the
pb/coder-lint-fix6
branch
2 times, most recently
from
d91d17a to
9e01fa4
Compare
dannykopping
approved these changes
Apr 13, 2026
Contributor
Author
Merge activity
|
pawbana
force-pushed
the
pb/coder-lint-fix5
branch
from
3720ab4 to
f206eb4
Compare
pawbana
force-pushed
the
pb/coder-lint-fix6
branch
from
9e01fa4 to
5aff9e5
Compare
pawbana
force-pushed
the
pb/coder-lint-fix6
branch
from
5aff9e5 to
b9d8cc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handled via pipe read side); properly checked errors from circuitbreaker.Execute and responseCopier.forwardResp in tests
NewRequestPayload); recorder.RecorderWrapper → recorder.WrappedRecorder (+ constructor NewWrappedRecorder)