fix: remove automatic terminal opening from ClaudeCodeSend

Foundation fix for #42 - removes automatic terminal opening behavior
from ClaudeCodeSend command to prevent focus_terminal errors when
terminal buffer is hidden.

- Remove terminal.open() calls after successful ClaudeCodeSend operations
- Update snacks terminal to check window validity before focus
- Update tests to reflect new behavior
- Update dev-config and documentation

This establishes the foundation for the complete fix which will address
the core focus_terminal issue in native terminal implementation.

Change-Id: Ide3692617e5c6ce721782eab9cf8f2eeeeef3df5
Signed-off-by: Thomas Kosiewski <tk@coder.com>

Author: ThomasK33

STORY.md

@@ -4,7 +4,7 @@
 
 While browsing Reddit at DevOpsCon in London, I stumbled upon a post that caught my eye: someone mentioned finding .vsix files in Anthropic's npm package for their Claude Code VS Code extension.
 
-Link to the Reddit post: https://www.reddit.com/r/ClaudeAI/comments/1klpzvl/hidden_jetbrains_vs_code_plugin_in_todays_release/
+Link to the Reddit post: <https://www.reddit.com/r/ClaudeAI/comments/1klpzvl/hidden_jetbrains_vs_code_plugin_in_todays_release/>
 
 My first thought? "No way, they wouldn't ship the source like that."
 
@@ -45,7 +45,7 @@ What I discovered was fascinating:
 
 Armed with this knowledge, I faced a new challenge: I wanted this in Neovim, but I didn't know Lua.
 
-So I did what any reasonable person would do in 2024 — I used AI to help me build it. Using Roo Code with Gemini 2.5 Pro, I scaffolded a Neovim plugin that implements the same protocol.
+So I did what any reasonable person would do in 2025 — I used AI to help me build it. Using Roo Code with Gemini 2.5 Pro, I scaffolded a Neovim plugin that implements the same protocol. (Note: Claude 4 models were not publicly available at the time of writing the extension.)
 
 The irony isn't lost on me: I used AI to reverse-engineer an AI tool, then used AI to build a plugin for AI.
 

dev-config.lua

@@ -1,12 +1,11 @@
 -- Development configuration for claudecode.nvim
 -- This is Thomas's personal config for developing claudecode.nvim
 -- Symlink this to your personal Neovim config:
--- ln -s ~/GitHub/claudecode.nvim/dev-config.lua ~/.config/nvim/lua/plugins/dev-claudecode.lua
+-- ln -s ~/projects/claudecode.nvim/dev-config.lua ~/.config/nvim/lua/plugins/dev-claudecode.lua
 
 return {
   "coder/claudecode.nvim",
   dev = true, -- Use local development version
-  dir = "~/GitHub/claudecode.nvim", -- Adjust path as needed
   keys = {
     -- AI/Claude Code prefix
     { "<leader>a", nil, desc = "AI/Claude Code" },

lua/claudecode/init.lua

@@ -443,17 +443,13 @@ function M._create_commands()
       end
       local sent_successfully = selection_module.send_at_mention_for_visual_selection(line1, line2)
       if sent_successfully then
-        -- Exit any potential visual mode (for consistency) and focus Claude terminal
+        -- Exit any potential visual mode (for consistency)
         pcall(function()
           if vim.api and vim.api.nvim_feedkeys then
             local esc = vim.api.nvim_replace_termcodes("<Esc>", true, false, true)
             vim.api.nvim_feedkeys(esc, "i", true)
           end
         end)
-        local terminal_ok, terminal = pcall(require, "claudecode.terminal")
-        if terminal_ok then
-          terminal.open({})
-        end
       end
     else
       logger.error("command", "ClaudeCodeSend: Failed to load selection module.")
@@ -481,24 +477,13 @@ function M._create_commands()
           local message = success_count == 1 and "Added 1 file to Claude context from visual selection"
             or string.format("Added %d files to Claude context from visual selection", success_count)
           logger.debug("command", message)
-
-          local terminal_ok, terminal = pcall(require, "claudecode.terminal")
-          if terminal_ok then
-            terminal.open({})
-          end
         end
         return
       end
     end
     local selection_module_ok, selection_module = pcall(require, "claudecode.selection")
     if selection_module_ok then
-      local sent_successfully = selection_module.send_at_mention_for_visual_selection()
-      if sent_successfully then
-        local terminal_ok, terminal = pcall(require, "claudecode.terminal")
-        if terminal_ok then
-          terminal.open({})
-        end
-      end
+      selection_module.send_at_mention_for_visual_selection()
     end
   end
 

lua/claudecode/terminal/snacks.lua

@@ -76,9 +76,12 @@ function M.open(cmd_string, env_table, config)
     terminal:focus()
     local term_buf_id = terminal.buf
     if term_buf_id and vim.api.nvim_buf_get_option(term_buf_id, "buftype") == "terminal" then
-      vim.api.nvim_win_call(terminal.win, function()
-        vim.cmd("startinsert")
-      end)
+      -- Check if window is valid before calling nvim_win_call
+      if terminal.win and vim.api.nvim_win_is_valid(terminal.win) then
+        vim.api.nvim_win_call(terminal.win, function()
+          vim.cmd("startinsert")
+        end)
+      end
     end
     return
   end

tests/unit/claudecode_send_command_spec.lua

@@ -216,7 +216,7 @@ describe("ClaudeCodeSend Command Range Functionality", function()
       assert(mock_selection_module.last_call.line2 == nil)
     end)
 
-    it("should exit visual mode and focus terminal on successful send", function()
+    it("should exit visual mode on successful send", function()
       assert(command_callback ~= nil, "Command callback should be set")
 
       local opts = {
@@ -228,7 +228,8 @@ describe("ClaudeCodeSend Command Range Functionality", function()
       command_callback(opts)
 
       assert.spy(_G.vim.api.nvim_feedkeys).was_called()
-      assert.spy(mock_terminal.open).was_called()
+      -- Terminal should not be automatically opened
+      assert.spy(mock_terminal.open).was_not_called()
     end)
 
     it("should handle server not running", function()