Skip to content

Commit f43c4e8

Browse files
committed
rename mac -> darwin and quote $@ in build targets
1 parent f4bf9a8 commit f43c4e8

3 files changed

Lines changed: 12 additions & 12 deletions

File tree

.CONTRIBUTING.md.swp

12 KB
Binary file not shown.

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ make bin/code-marketplace-linux-amd64
2222
```
2323

2424
Available targets:
25-
- `bin/code-marketplace-mac-amd64`
26-
- `bin/code-marketplace-mac-arm64`
25+
- `bin/code-marketplace-darwin-amd64`
26+
- `bin/code-marketplace-darwin-arm64`
2727
- `bin/code-marketplace-linux-amd64`
2828
- `bin/code-marketplace-linux-arm64`
2929
- `bin/code-marketplace-windows-amd64`

Makefile

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,27 +31,27 @@ LDFLAGS=-ldflags "-X github.com/coder/code-marketplace/buildinfo.tag=$(TAG)"
3131
$(shell mkdir -p bin)
3232

3333
# Individual build targets for each OS/arch combination
34-
bin/code-marketplace-mac-amd64: $(GO_SRC) go.mod go.sum
35-
CGO_ENABLED=0 GOOS=darwin GOARCH=amd64 go build $(LDFLAGS) -o $@ ./cmd/marketplace/main.go
34+
bin/code-marketplace-darwin-amd64: $(GO_SRC) go.mod go.sum
35+
CGO_ENABLED=0 GOOS=darwin GOARCH=amd64 go build $(LDFLAGS) -o "$@" ./cmd/marketplace/main.go
3636

37-
bin/code-marketplace-mac-arm64: $(GO_SRC) go.mod go.sum
38-
CGO_ENABLED=0 GOOS=darwin GOARCH=arm64 go build $(LDFLAGS) -o $@ ./cmd/marketplace/main.go
37+
bin/code-marketplace-darwin-arm64: $(GO_SRC) go.mod go.sum
38+
CGO_ENABLED=0 GOOS=darwin GOARCH=arm64 go build $(LDFLAGS) -o "$@" ./cmd/marketplace/main.go
3939

4040
bin/code-marketplace-linux-amd64: $(GO_SRC) go.mod go.sum
41-
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build $(LDFLAGS) -o $@ ./cmd/marketplace/main.go
41+
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build $(LDFLAGS) -o "$@" ./cmd/marketplace/main.go
4242

4343
bin/code-marketplace-linux-arm64: $(GO_SRC) go.mod go.sum
44-
CGO_ENABLED=0 GOOS=linux GOARCH=arm64 go build $(LDFLAGS) -o $@ ./cmd/marketplace/main.go
44+
CGO_ENABLED=0 GOOS=linux GOARCH=arm64 go build $(LDFLAGS) -o "$@" ./cmd/marketplace/main.go
4545

4646
bin/code-marketplace-windows-amd64: $(GO_SRC) go.mod go.sum
47-
CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build $(LDFLAGS) -o $@ ./cmd/marketplace/main.go
47+
CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build $(LDFLAGS) -o "$@" ./cmd/marketplace/main.go
4848

4949
bin/code-marketplace-windows-arm64: $(GO_SRC) go.mod go.sum
50-
CGO_ENABLED=0 GOOS=windows GOARCH=arm64 go build $(LDFLAGS) -o $@ ./cmd/marketplace/main.go
50+
CGO_ENABLED=0 GOOS=windows GOARCH=arm64 go build $(LDFLAGS) -o "$@" ./cmd/marketplace/main.go
5151

5252
# Main build target - builds all platforms
53-
build: bin/code-marketplace-mac-amd64 \
54-
bin/code-marketplace-mac-arm64 \
53+
build: bin/code-marketplace-darwin-amd64 \
54+
bin/code-marketplace-darwin-arm64 \
5555
bin/code-marketplace-linux-amd64 \
5656
bin/code-marketplace-linux-arm64 \
5757
bin/code-marketplace-windows-amd64 \

0 commit comments

Comments
 (0)