Skip to content

Commit 5c1bf18

Browse files
committed
Fix protected field error
1 parent aeada8d commit 5c1bf18

File tree

2 files changed

+23
-0
lines changed

2 files changed

+23
-0
lines changed

patches/fix-build.diff

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
Fix protected field error
2+
3+
The mangler is reporting this error:
4+
5+
WARN: 'setEditorVisible' from lib/vscode/src/vs/workbench/browser/parts/editor/editorPane.ts:160 became PUBLIC because of: lib/vscode/src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugEditor.ts:304
6+
ERROR: Protected fields have been made PUBLIC. This hurts minification and is therefore not allowed. Review the WARN messages further above
7+
8+
No idea how VS Code is dealing with this in their own builds.
9+
10+
Index: code-server/lib/vscode/src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugEditor.ts
11+
===================================================================
12+
--- code-server.orig/lib/vscode/src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugEditor.ts
13+
+++ code-server/lib/vscode/src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugEditor.ts
14+
@@ -301,7 +301,7 @@ export class ChatDebugEditor extends Edi
15+
}
16+
}
17+
18+
- override setEditorVisible(visible: boolean): void {
19+
+ protected override setEditorVisible(visible: boolean): void {
20+
super.setEditorVisible(visible);
21+
if (visible) {
22+
this.telemetryService.publicLog2<{}, ChatDebugPanelOpenedClassification>('chatDebugPanelOpened');

patches/series

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,4 @@ clipboard.diff
2222
display-language.diff
2323
trusted-domains.diff
2424
signature-verification.diff
25+
fix-build.diff

0 commit comments

Comments
 (0)