Skip to content

Commit d74b002

Browse files
committed
Build native modules from source
Another thing I managed to miss when refactoring CI.
1 parent 394c6fc commit d74b002

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

.github/workflows/release.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,11 @@ jobs:
4545
# Cross-compile target.
4646
VSCODE_ARCH: ${{ matrix.vscode_arch }}
4747
npm_config_arch: ${{ matrix.npm_arch }}
48+
# Ensure native modules are built from source to avoid prebuilds and use
49+
# the correct version of glibc.
50+
npm_config_build_from_source: true
4851
# Gulp target name.
52+
# TODO: Pull from VSCODE_ARCH instead.
4953
VSCODE_TARGET: ${{ format('linux-{0}', matrix.vscode_arch) }}
5054

5155
steps:
@@ -125,6 +129,8 @@ jobs:
125129
VSCODE_TARGET: ${{ matrix.vscode_target }}
126130
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
127131
TAG: ${{ inputs.version || github.ref_name }}
132+
# Ensure native modules are built from source to avoid prebuilds.
133+
npm_config_build_from_source: true
128134

129135
steps:
130136
# The version of node-gyp we use depends on distutils but it was removed

0 commit comments

Comments
 (0)