Skip to content

Commit 766e024

Browse files
authored
fix: remove dependency on WPAD (#169)
Existing Coder binary works without this dependency on the service running, tested on my own machine. It seems that the only `tailscaled` component that requires WPAD is `tshttpproxy` which we don't use.
1 parent c54693e commit 766e024

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

Installer/Program.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,12 +227,12 @@ private static int BuildMsiPackage(MsiOptions opts)
227227
RestartServiceDelayInSeconds = 30,
228228
ResetPeriodInDays = 1,
229229
PreShutdownDelay = 1000 * 60 * 3, // default
230-
// This matches Tailscale's service dependencies, with one omission: iphlpsvc. We do not
231-
// use any of the IPv6 transition technologies provided by that service.
230+
// This matches Tailscale's service dependencies, with two omissions:
231+
// - iphlpsvc - We do not use any of the IPv6 transition technologies provided by that service.
232+
// - WinHttpAutoProxySvc - We don't use tshttpproxy, so we don't require WPAD.
232233
DependsOn =
233234
[
234235
new ServiceDependency("netprofm"), // Network List Service
235-
new ServiceDependency("WinHttpAutoProxySvc"), // WinHTTP Web Proxy Auto-Discovery Service
236236
],
237237
};
238238
var shortcut = new FileShortcut("Coder Desktop", "%StartMenuFolder%")

0 commit comments

Comments
 (0)