fix: invalid references to http client & cli (#259)

Each environment holds a reference to the http client and the cli
mainly for operations like start, stop, update, etc... performed by
either one or the other.

In the past we recreated the environment instances each time we polled,
effectively updating the references to the cli and http client.
This was really important for the cases where Coder Toolbox was already
running and a URI was executed. In this case we recreate new instances
of
the http client and cli that are the used by the poller to create a new
list of environments. However, not too long we discovered that
recreating
the environments instances each time has unwanted effects. The obvious
fix
was to update the existing env. instances instead of creating new ones.
But the update failed to take into account that the cli and http client
references also need to a refresh after a URI execution.

As a result, environment actions stopped working after new instances
were created
by the URI handler. This fix ensures those references are properly
refreshed.

Author: fioan89

CHANGELOG.md

@@ -6,6 +6,10 @@
 
 - support for configuring the SSH connection timeout, defaults to 10 seconds
 
+### Fixed
+
+- environment actions failing after URI execution by refreshing http client and CLI references
+
 ## 0.8.4 - 2026-01-20
 
 ### Fixed

src/main/kotlin/com/coder/toolbox/CoderRemoteEnvironment.kt

@@ -49,8 +49,8 @@ private val POLL_INTERVAL = 5.seconds
  */
 class CoderRemoteEnvironment(
     private val context: CoderToolboxContext,
-    private val client: CoderRestClient,
-    private val cli: CoderCLIManager,
+    internal var client: CoderRestClient,
+    internal var cli: CoderCLIManager,
     private var workspace: Workspace,
     private var agent: WorkspaceAgent,
 ) : RemoteProviderEnvironment("${workspace.name}.${agent.name}"), BeforeConnectionHook, AfterDisconnectHook {
@@ -351,8 +351,6 @@ class CoderRemoteEnvironment(
         }
     }
 
-    fun isConnected(): Boolean = isConnected.value
-
     /**
      * An environment is equal if it has the same ID.
      */
@@ -371,4 +369,12 @@ class CoderRemoteEnvironment(
     override fun toString(): String {
         return "CoderRemoteEnvironment(name='$name')"
     }
+
+    /**
+     * Update the client and CLI manager for this environment.
+     */
+    fun updateClientAndCli(client: CoderRestClient, cli: CoderCLIManager) {
+        this.client = client
+        this.cli = cli
+    }
 }

src/main/kotlin/com/coder/toolbox/CoderRemoteProvider.kt

@@ -441,6 +441,7 @@ class CoderRemoteProvider(
         }
         this.client = newRestClient
         this.cli = newCli
+        lastEnvironments.forEach { it.updateClientAndCli(newRestClient, newCli) }
         pollJob = poll(newRestClient, newCli)
         context.logger.info("Workspace poll job with name ${pollJob.toString()} was created while handling URI")
         return newRestClient to newCli
@@ -521,6 +522,7 @@ class CoderRemoteProvider(
         }
         this.client = client
         this.cli = cli
+        lastEnvironments.forEach { it.updateClientAndCli(client, cli) }
         environments.showLoadingMessage()
         if (context.settingsStore.useAppNameAsTitle) {
             context.logger.info("Displaying ${client.appName} as main page title")