Support Toolbox 3.5 provider header rendering#316
Merged
Conversation
Toolbox 3.5 removes the provider top section when canCreateNewEnvironments is false. Coder used that section to render the deployment URL and account dropdown, so the URL header stayed stuck on Coder and the dropdown never appeared. As an extra I changed all calls to showPluginEnvironmentsPage(false) when returning to the provider page. There is no reason to expand the header bar right now because Coder only renders the URL and account button there. Original Toolbox issue that was fixed in 3.5: https://youtrack.jetbrains.com/issue/TBX-17235
Collaborator
Author
|
Expanded: Non expanded version: |
Member
Which of them is the new behavior? I don't understand what do we get from the expanded behaviour if it has nothing inside it. |
Collaborator
Author
|
The new behavior is the non-expanded version. Previously, the flag did not matter because of canCreateNewEnvironments bug. |
matifali
approved these changes
Jun 11, 2026
matifali
left a comment
matifali
left a comment
Member
There was a problem hiding this comment.
Nota. code review, but for the new behavior ✅
code-asher
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toolbox 3.5 removes the provider top section when
canCreateNewEnvironmentsis false. Coder used that section to render the deployment URL and account dropdown, so the URL header stayed stuck on Coder and the dropdown never appeared.Because we changed
canCreateNewEnvironmentsto true, Toolbox 3.5 renders that top/header area again. ButgetAccountDropDown()always returnsaccountDropdownField, and its initial label is "". So I hid it until a real Coder session exists, then made it visible after login when we set the username.As an extra I changed all calls to
showPluginEnvironmentsPage(false)when returning to the provider page. There is no reason to expand the header bar right now because Coder only renders the URL and account button there.Original Toolbox issue that was fixed in 3.5:
https://youtrack.jetbrains.com/issue/TBX-17235