Skip to content

Commit 2fafd34

Browse files
committed
fix: map coder 429 errors to too many requests
1 parent b6b0fdc commit 2fafd34

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

internal/aggregated/coder/errors.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ func MapCoderError(err error, resource schema.GroupResource, name string) error
4545
return apierrors.NewBadRequest(message)
4646
case http.StatusUnauthorized:
4747
return apierrors.NewUnauthorized(message)
48+
case http.StatusTooManyRequests:
49+
return apierrors.NewTooManyRequests(message, 0)
4850
default:
4951
if statusCode >= http.StatusBadRequest && statusCode < http.StatusInternalServerError {
5052
return apierrors.NewBadRequest(message)

internal/aggregated/coder/errors_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,15 +83,15 @@ func TestMapCoderError(t *testing.T) {
8383
},
8484
},
8585
{
86-
name: "maps other client errors to bad request",
86+
name: "maps too many requests",
8787
err: withCoderMessage(
8888
codersdk.NewTestError(http.StatusTooManyRequests, http.MethodGet, "https://coder.example.com"),
8989
"rate limited",
9090
),
9191
assertMapping: func(t *testing.T, err error) {
9292
t.Helper()
93-
if !apierrors.IsBadRequest(err) {
94-
t.Fatalf("expected BadRequest, got %v", err)
93+
if !apierrors.IsTooManyRequests(err) {
94+
t.Fatalf("expected TooManyRequests, got %v", err)
9595
}
9696
},
9797
},

0 commit comments

Comments
 (0)