fix: report async workspace deletes correctly

Author: ThomasK33

internal/aggregated/storage/storage_test.go

@@ -697,8 +697,8 @@ func TestWorkspaceStorageCRUDWithCoderSDK(t *testing.T) {
 	if err != nil {
 		t.Fatalf("expected workspace delete to succeed: %v", err)
 	}
-	if !deleted {
-		t.Fatal("expected delete to report deleted=true")
+	if deleted {
+		t.Fatal("expected delete to report deleted=false for async delete transition")
 	}
 	if !containsTransition(state.buildTransitionsSnapshot(), codersdk.WorkspaceTransitionDelete) {
 		t.Fatal("expected delete to queue delete transition")

internal/aggregated/storage/workspace.go

@@ -481,7 +481,9 @@ func (s *WorkspaceStorage) Delete(
 		return nil, false, coder.MapCoderError(err, aggregationv1alpha1.Resource("coderworkspaces"), name)
 	}
 
-	return &metav1.Status{Status: metav1.StatusSuccess}, true, nil
+	// Deletion is asynchronous in Coder: we only enqueue a delete build transition here.
+	// Report deleted=false so Kubernetes callers know the resource is not gone yet.
+	return &metav1.Status{Status: metav1.StatusSuccess}, false, nil
 }
 
 // ConvertToTable converts a workspace object or list into kubectl table output.