Skip to content

Commit b7da935

Browse files
committed
fix: allow workspace deletecollection RBAC grants
1 parent 5ae5c80 commit b7da935

2 files changed

Lines changed: 18 additions & 3 deletions

File tree

config/rbac/role.yaml

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,10 @@ rules:
2727
resources:
2828
- persistentvolumeclaims
2929
- pods
30-
- secrets
31-
- serviceaccounts
32-
- services
3330
verbs:
3431
- create
3532
- delete
33+
- deletecollection
3634
- get
3735
- list
3836
- patch
@@ -44,6 +42,20 @@ rules:
4442
- pods/log
4543
verbs:
4644
- get
45+
- apiGroups:
46+
- ""
47+
resources:
48+
- secrets
49+
- serviceaccounts
50+
- services
51+
verbs:
52+
- create
53+
- delete
54+
- get
55+
- list
56+
- patch
57+
- update
58+
- watch
4759
- apiGroups:
4860
- aggregation.coder.com
4961
resources:
@@ -62,6 +74,7 @@ rules:
6274
verbs:
6375
- create
6476
- delete
77+
- deletecollection
6578
- get
6679
- list
6780
- patch

internal/controller/codercontrolplane_controller.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,8 @@ type CoderControlPlaneReconciler struct {
200200
// +kubebuilder:rbac:groups="",resources=services,verbs=get;list;watch;create;update;patch;delete
201201
// +kubebuilder:rbac:groups="",resources=secrets,verbs=get;list;watch;create;update;patch;delete
202202
// +kubebuilder:rbac:groups="",resources=serviceaccounts,verbs=get;list;watch;create;update;patch;delete
203+
// +kubebuilder:rbac:groups="",resources=pods;persistentvolumeclaims,verbs=deletecollection
204+
// +kubebuilder:rbac:groups=apps,resources=deployments,verbs=deletecollection
203205
// +kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=roles;rolebindings,verbs=get;list;watch;create;update;patch;delete
204206
// +kubebuilder:rbac:groups=networking.k8s.io,resources=ingresses,verbs=get;list;watch;create;update;patch;delete
205207
// +kubebuilder:rbac:groups=gateway.networking.k8s.io,resources=httproutes,verbs=get;list;watch;create;update;patch;delete

0 commit comments

Comments
 (0)