feat: implement retry mechanism for log processing#136
Merged
Conversation
deansheather
left a comment
deansheather
left a comment
Member
There was a problem hiding this comment.
What happens when the log never succeeds? Maybe because an agent token is no longer valid. Judging by the code, logstream will attempt to send it to coder Forever
| l.logger.Error(ctx, "max retries exceeded", | ||
| slog.F("retryCount", rs.retryCount), | ||
| slog.F("maxRetries", l.maxRetries)) | ||
| rs.exhausted = true |
Member
There was a problem hiding this comment.
This will be kept in memory forever now right?
Contributor
Author
There was a problem hiding this comment.
It will be kept in memory until the pod is deleted.
https://github.com/coder/coder-logstream-kube/blob/kacpersaw/feat-log-queue/logger.go#L562
…efault of 15 retries for log send failures.
deansheather
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119
This PR adds error handling and retry functionality to the log streaming by adding exponential backoff retry logic for failed log operations.
Changes
PostLogSourceandAgent dRPC clientfailures to handle connection issuesWith this PR, users will see more reliable logs from pod startup in their Coder workspace, including pod events before container startup that were previously not visible.