Skip to content

feat: add CODER_FIELD_SELECTOR and CODER_LABEL_SELECTOR#196

Merged
rowansmithau merged 1 commit into
mainfrom
rowan/label_and_field_env_vars
Jun 16, 2026
Merged

feat: add CODER_FIELD_SELECTOR and CODER_LABEL_SELECTOR#196
rowansmithau merged 1 commit into
mainfrom
rowan/label_and_field_env_vars

Conversation

@rowansmithau

@rowansmithau rowansmithau commented Jun 16, 2026

Copy link
Copy Markdown
Member

these env vars were missing from the code despite being mentioned in the readme:

https://github.com/coder/coder-logstream-kube/blob/main/README.md?plain=1#L59-L60

| `--field-selector`, `-f` | `CODER_FIELD_SELECTOR` | Kubernetes field selector for filtering pods |
| `--label-selector`, `-l` | `CODER_LABEL_SELECTOR` | Kubernetes label selector for filtering pods |

Adding them so they can be used as we don't expose args in the chart.

@rowansmithau rowansmithau self-assigned this Jun 16, 2026
@rowansmithau rowansmithau added the enhancement New feature or request label Jun 16, 2026
@rowansmithau rowansmithau marked this pull request as ready for review June 16, 2026 04:35
@rowansmithau rowansmithau merged commit d9b15e9 into main Jun 16, 2026
4 checks passed
@rowansmithau rowansmithau deleted the rowan/label_and_field_env_vars branch June 16, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants