fix: update log level to debug for in progress events sent to Kubernetes/Coder#198
Merged
Conversation
rowansmithau
changed the title
matifali
approved these changes
Jun 16, 2026
matifali
left a comment
matifali
left a comment
Member
There was a problem hiding this comment.
This looks good to me. Not sure if there are any side affcts of this change in behaviour..
Member
There was a problem hiding this comment.
This corrects the behaviour of events sent to Kubernetes to ensure Coder shows them with a green border instead of a blue, thus not implying the workspace is ready.
FWICT the workspace agent border is not influenced by the logs, it's only influenced by the workspace agent lifecycle state machine. That aligns with my prior understanding.
What this PR does change, however, is it adds the blue background around the debug log lines. That appears to be the only thing it changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #145
This corrects the behaviour of events sent to Kubernetes to ensure Coder shows them with a blue border instead of a green, thus not implying the workspace is ready.
builds on the changes implemented in #168
With a test build, an example of image pull failure staying blue:
blue.mov
With a test build, an example of image pull staying blue (image has to be pulled, does not exist locally):
blue-image-pull-delay.mov