Skip to content

Commit c3400b0

Browse files
committed
fix: address review feedback on vscode-web docs and test
- Correct the Coder integration note: the health check probes /version, not /healthz (which the standalone web server does not expose), and regenerate the README accordingly. - Pass the extensions scenario option as the canonical comma-separated string instead of relying on the CLI's array-to-string coercion.
1 parent 7ac50c7 commit c3400b0

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

src/vscode-web/NOTES.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ append `?folder=/path/to/folder` to the URL.
4747
## Coder integration
4848

4949
When used inside a [Coder workspace with dev container support](https://coder.com/docs/admin/templates/extending-templates/devcontainers),
50-
the feature registers a `vscode-web` app (with a `/healthz` health check) on
51-
the workspace dashboard via `customizations.coder.apps`. The `app*` options
50+
the feature registers a `vscode-web` app on the workspace dashboard via
51+
`customizations.coder.apps`. Its health check probes the `/version` endpoint
52+
(the standalone web server exposes no `/healthz`). The `app*` options
5253
only affect this Coder app metadata, not the server itself.

src/vscode-web/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,9 @@ append `?folder=/path/to/folder` to the URL.
8484
## Coder integration
8585

8686
When used inside a [Coder workspace with dev container support](https://coder.com/docs/admin/templates/extending-templates/devcontainers),
87-
the feature registers a `vscode-web` app (with a `/healthz` health check) on
88-
the workspace dashboard via `customizations.coder.apps`. The `app*` options
87+
the feature registers a `vscode-web` app on the workspace dashboard via
88+
`customizations.coder.apps`. Its health check probes the `/version` endpoint
89+
(the standalone web server exposes no `/healthz`). The `app*` options
8990
only affect this Coder app metadata, not the server itself.
9091

9192

test/vscode-web/scenarios.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"features": {
3939
"vscode-web": {
4040
"acceptLicenseTerms": true,
41-
"extensions": ["tamasfe.even-better-toml", "redhat.vscode-yaml"]
41+
"extensions": "tamasfe.even-better-toml,redhat.vscode-yaml"
4242
}
4343
}
4444
},

0 commit comments

Comments
 (0)