fix: allow processing multiple terminal responses from WASM#103
Merged
Conversation
Contributor
|
Awesome thanks for this |
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
sreya
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fix addresses a hanging issue when terminal integrations that buffer incoming data during async initialization (for example: https://github.com/jupyterlab/jupyterlab/blob/main/packages/terminal/src/widget.ts#L75-L115) can trigger multiple terminal query responses in a single write call.
things like neovim/nushell that send multiple queries and block waiting for responses, which hangs because currently only the first response was being sent back.
for example, trying to run neovim in jupyterlab would hang after the first response:
after the fix, neovim starts up successfully in jupyterlab:
