fix(demo): correct path resolution for ghostty-web package#57
Merged
Conversation
The findGhosttyWeb() function was incorrectly resolving the package root path. The regex /[/\\]dist[/\\].*$/ already strips the path down to the package root (e.g., '/path/to/node_modules/ghostty-web'), but then path.dirname() was called which removed one more directory level, resulting in '/path/to/node_modules' instead. This caused the 'Could not find ghostty-web package' error when running npx @ghostty-web/demo because it was looking for the WASM file and dist folder in node_modules/ instead of node_modules/ghostty-web/. Fixes the issue where npx @ghostty-web/demo@next fails with: Error: Could not find ghostty-web package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.