Commit 7b8e1a8
authored
feat: add value-expression AST nodes for composing call chains (#84)
* feat: add value-expression AST nodes for composing call chains
Adds seven bindings nodes that let mutations build TypeScript value
expressions structurally instead of via string concatenation:
- IdentifierExpression: bare value-position identifier (`z`, `BaseSchema`).
- PropertyAccessExpression: `expr.name`, the building block for method
chains like `z.string`.
- CallExpression: `expr(args...)`, composes with PropertyAccessExpression
to build `z.string()` and chained `z.string().optional()`.
- ObjectLiteralExpression + PropertyAssignment: `{ k: v, ... }` in value
position, distinct from TypeLiteralNode which emits a type literal.
- ArrowFunction + Parameter: `(params): retType => body` so callers can
produce things like `(): z.ZodType => FooSchema` for cyclic references.
- TypeQuery: `typeof name`, used as a generic argument such as the
`typeof FooSchema` inside `z.infer<typeof FooSchema>`.
Each node has a corresponding `ts.factory.create*` wrapper in
typescript-engine/src/index.ts, a goja-backed builder in bindings.go, and
dispatch through ToTypescriptNode / ToTypescriptExpressionNode.
typescript-engine/dist/main.js is rebuilt to ship the new factories.
bindings/expressions_test.go round-trips every node and several
compositions through goja, including the chained-call shape
`z.string().optional()`, an inline object literal with property-order
preservation, and the `z.lazy((): z.ZodType => Schema)` self-reference
form. These cover the surface a follow-up zod mutation needs without
binding the bindings to any zod-specific opinions.
Generated by Coder Agents on behalf of @Emyrk.
* refactor: type IdentifierExpression.Name as Identifier
Align with ReferenceType.Name, VariableDeclaration.Name, and Alias.Name so
the same qualified-name handle flows through value-position references.
Cross-package Prefix set during Go parsing now reaches the emitted name
via .Ref() instead of being silently dropped.
Doc comment on IdentifierExpression now spells out the distinction from
bindings.Identifier: Identifier is a parser-layer qualified-name handle
and is not itself a Node; IdentifierExpression is a tree-layer Node that
embeds an Identifier in expression position.
Test split into bare-name and prefix-is-applied subcases. The prefix case
pins the new behavior; without it, an IdentifierExpression carrying a
prefixed Identifier would emit "Schema" instead of "ExternalSchema" and
would not match the prefixed declaration the rest of guts emits for the
same Identifier.
Generated by Coder Agents on behalf of @Emyrk.
* refactor: review fixes for expression bindings
Three review findings, applied together:
1. TypeQuery.Name is now Identifier instead of string. Same reason as the
IdentifierExpression refactor: `typeof FooSchema` references a declared
TS name, and the prefix set during Go parsing must flow through .Ref()
so the TypeQuery and a matching IdentifierExpression for the same
prefixed Identifier emit aligned names. Without this, a prefixed
declaration would emit `typeof Foo` while the value-position reference
emits `ExternalFoo`. Doc updated to spell out the invariant and a
prefix_is_applied subtest pins the new behavior.
2. Test helper zMethodCall renamed to methodCall(receiver, method, args).
The bindings know nothing about zod; the helper shouldn't either. The
helper had "z" hardcoded as the receiver, which leaked the zod
motivation into general-purpose tests. The new signature reads
methodCall("z", "string"), exactly as descriptive at the call site,
without baking domain assumptions into the helper name.
3. ObjectLiteralExpression doc now calls out the modeled subset. TS's
ObjectLiteralElementLike covers PropertyAssignment,
ShorthandPropertyAssignment, SpreadAssignment, MethodDeclaration, and
accessors. We model only PropertyAssignment; the doc says so, matching
the existing pattern on ImportDeclaration ("Only the named-imports
form is modeled").
Generated by Coder Agents on behalf of @Emyrk.1 parent 955fb63 commit 7b8e1a8
5 files changed
Lines changed: 649 additions & 1 deletion
File tree
- bindings
- typescript-engine
- dist
- src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
36 | 40 | | |
37 | 41 | | |
38 | 42 | | |
| |||
135 | 139 | | |
136 | 140 | | |
137 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
138 | 154 | | |
139 | 155 | | |
140 | 156 | | |
| |||
864 | 880 | | |
865 | 881 | | |
866 | 882 | | |
| 883 | + | |
| 884 | + | |
| 885 | + | |
| 886 | + | |
| 887 | + | |
| 888 | + | |
| 889 | + | |
| 890 | + | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
| 895 | + | |
| 896 | + | |
| 897 | + | |
| 898 | + | |
| 899 | + | |
| 900 | + | |
| 901 | + | |
| 902 | + | |
| 903 | + | |
| 904 | + | |
| 905 | + | |
| 906 | + | |
| 907 | + | |
| 908 | + | |
| 909 | + | |
| 910 | + | |
| 911 | + | |
| 912 | + | |
| 913 | + | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
| 938 | + | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
| 945 | + | |
| 946 | + | |
| 947 | + | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
| 954 | + | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
| 1005 | + | |
| 1006 | + | |
| 1007 | + | |
| 1008 | + | |
| 1009 | + | |
| 1010 | + | |
| 1011 | + | |
| 1012 | + | |
| 1013 | + | |
| 1014 | + | |
| 1015 | + | |
| 1016 | + | |
| 1017 | + | |
| 1018 | + | |
| 1019 | + | |
| 1020 | + | |
| 1021 | + | |
| 1022 | + | |
| 1023 | + | |
| 1024 | + | |
| 1025 | + | |
| 1026 | + | |
| 1027 | + | |
| 1028 | + | |
| 1029 | + | |
| 1030 | + | |
| 1031 | + | |
| 1032 | + | |
| 1033 | + | |
| 1034 | + | |
| 1035 | + | |
| 1036 | + | |
| 1037 | + | |
| 1038 | + | |
| 1039 | + | |
| 1040 | + | |
| 1041 | + | |
| 1042 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
0 commit comments