🤖 refactor: auto-cleanup (#3165)

## Summary

Long-lived auto-cleanup PR that accumulates low-risk,
behavior-preserving refactors picked from recent `main` commits.

## Current cleanup

**Deduplicate identical `normalizeAdvisor*` helpers**
(`src/browser/features/Settings/Sections/AdvisorToolExperimentConfig.tsx`)

`normalizeAdvisorMaxUsesPerTurn` and `normalizeAdvisorMaxOutputTokens`
had byte-for-byte identical function bodies (coerce a nullable number to
a positive integer or return null). Replaced both with a single
`normalizePositiveIntOrNull` helper.

<details><summary>Previous cleanups</summary>

**Remove dead `toLiveBashOutputView` function**
(`src/browser/utils/messages/liveBashOutputBuffer.ts`)

`toLiveBashOutputView` was exported but never imported or called
anywhere in the codebase. Since `LiveBashOutputInternal extends
LiveBashOutputView`, the `WorkspaceStore.getBashToolLiveOutput` returns
the internal object directly for reference stability with
`useSyncExternalStore`, making this converter function unnecessary dead
code.

</details>

## Validation

- TypeScript compilation passes (both renderer and main configs)
- ESLint passes
- Advisor experiment settings tests pass (4/4)
- Formatting check passes

Auto-cleanup checkpoint: 7a2d18f

---

_Generated with `mux` • Model: `anthropic:claude-opus-4-6` • Thinking:
`xhigh` • Cost: `$-`_

<!-- mux-attribution: model=anthropic:claude-opus-4-6 thinking=xhigh
costs=- -->

---------

Co-authored-by: mux-bot[bot] <264182336+mux-bot[bot]@users.noreply.github.com>

Author: mux-bot[bot]

src/browser/features/Settings/Sections/AdvisorToolExperimentConfig.tsx

@@ -58,15 +58,8 @@ function normalizeAdvisorModelString(value: string | null | undefined): string |
   return trimmedValue;
 }
 
-function normalizeAdvisorMaxUsesPerTurn(value: number | null | undefined): number | null {
-  if (!Number.isInteger(value) || value == null || value <= 0) {
-    return null;
-  }
-
-  return value;
-}
-
-function normalizeAdvisorMaxOutputTokens(value: number | null | undefined): number | null {
+/** Coerce a nullable number to a positive integer or null. */
+function normalizePositiveIntOrNull(value: number | null | undefined): number | null {
   if (!Number.isInteger(value) || value == null || value <= 0) {
     return null;
   }
@@ -198,10 +191,8 @@ export function AdvisorToolExperimentConfig() {
         const normalizedModelString = normalizeAdvisorModelString(cfg.advisorModelString);
         const normalizedThinkingLevel =
           coerceThinkingLevel(cfg.advisorThinkingLevel) ?? THINKING_LEVEL_OFF;
-        const normalizedMaxUsesPerTurn = normalizeAdvisorMaxUsesPerTurn(cfg.advisorMaxUsesPerTurn);
-        const normalizedMaxOutputTokens = normalizeAdvisorMaxOutputTokens(
-          cfg.advisorMaxOutputTokens
-        );
+        const normalizedMaxUsesPerTurn = normalizePositiveIntOrNull(cfg.advisorMaxUsesPerTurn);
+        const normalizedMaxOutputTokens = normalizePositiveIntOrNull(cfg.advisorMaxOutputTokens);
         // Match the backend starter cap when the setting is unset; only an explicit null is
         // the user's Unlimited opt-in.
         const nextMaxUsesMode: AdvisorMode =

src/browser/utils/messages/liveBashOutputBuffer.ts

@@ -143,13 +143,3 @@ export function appendLiveBashOutputChunk(
 
   return next;
 }
-
-export function toLiveBashOutputView(state: LiveBashOutputInternal): LiveBashOutputView {
-  return {
-    stdout: state.stdout,
-    stderr: state.stderr,
-    combined: state.combined,
-    truncated: state.truncated,
-    phase: state.phase,
-  };
-}