🤖 refactor: extract duplicated strings to constants

- Add NOTE_READ_FILE_RETRY, NOTE_READ_FILE_FIRST_RETRY, NOTE_READ_FILE_AGAIN_RETRY constants
- Add TOOL_EDIT_WARNING constant for tool descriptions
- Update all usages to reference constants (7 locations)
- Eliminates string duplication across tool definitions and error handling

Author: ammar-agent

src/services/tools/file_edit_insert.ts

@@ -3,7 +3,7 @@ import type { FileEditInsertToolResult } from "@/types/tools";
 import type { ToolConfiguration, ToolFactory } from "@/utils/tools/tools";
 import { TOOL_DEFINITIONS } from "@/utils/tools/toolDefinitions";
 import { validatePathInCwd, validateNoRedundantPrefix } from "./fileCommon";
-import { EDIT_FAILED_NOTE_PREFIX } from "@/types/tools";
+import { EDIT_FAILED_NOTE_PREFIX, NOTE_READ_FILE_RETRY } from "@/types/tools";
 import { executeFileEditOperation } from "./file_edit_operation";
 import { RuntimeError } from "@/runtime/Runtime";
 import { fileExists } from "@/utils/runtime/fileExists";
@@ -92,7 +92,7 @@ export const createFileEditInsertTool: ToolFactory = (config: ToolConfiguration)
               return {
                 success: false,
                 error: `line_offset ${line_offset} is beyond file length (${lines.length} lines)`,
-                note: `${EDIT_FAILED_NOTE_PREFIX} The file has ${lines.length} lines. Read the file to get current content, then retry.`,
+                note: `${EDIT_FAILED_NOTE_PREFIX} The file has ${lines.length} lines. ${NOTE_READ_FILE_RETRY}`,
               };
             }
 

src/services/tools/file_edit_replace_shared.ts

@@ -5,7 +5,12 @@
  * providing the core logic while keeping the tool definitions simple for AI providers.
  */
 
-import { EDIT_FAILED_NOTE_PREFIX } from "@/types/tools";
+import {
+  EDIT_FAILED_NOTE_PREFIX,
+  NOTE_READ_FILE_FIRST_RETRY,
+  NOTE_READ_FILE_RETRY,
+  NOTE_READ_FILE_AGAIN_RETRY,
+} from "@/types/tools";
 
 interface OperationMetadata {
   edits_applied: number;
@@ -56,7 +61,7 @@ export function handleStringReplace(
       success: false,
       error:
         "old_string not found in file. The text to replace must exist exactly as written in the file.",
-      note: `${EDIT_FAILED_NOTE_PREFIX} The old_string does not exist in the file. Read the file first to get the exact current content, then retry.`,
+      note: `${EDIT_FAILED_NOTE_PREFIX} The old_string does not exist in the file. ${NOTE_READ_FILE_FIRST_RETRY}`,
     };
   }
 
@@ -147,7 +152,7 @@ export function handleLineReplace(
     return {
       success: false,
       error: `start_line ${args.start_line} exceeds current file length (${lines.length}).`,
-      note: `${EDIT_FAILED_NOTE_PREFIX} The file has ${lines.length} lines. Read the file to get current content, then retry.`,
+      note: `${EDIT_FAILED_NOTE_PREFIX} The file has ${lines.length} lines. ${NOTE_READ_FILE_RETRY}`,
     };
   }
 
@@ -158,7 +163,7 @@ export function handleLineReplace(
     return {
       success: false,
       error: `expected_lines validation failed. Current lines [${currentRange.join("\n")}] differ from expected [${args.expected_lines.join("\n")}].`,
-      note: `${EDIT_FAILED_NOTE_PREFIX} The file content changed since you last read it. Read the file again and retry.`,
+      note: `${EDIT_FAILED_NOTE_PREFIX} The file content changed since you last read it. ${NOTE_READ_FILE_AGAIN_RETRY}`,
     };
   }
 

src/types/tools.ts

@@ -132,6 +132,20 @@ export const WRITE_DENIED_PREFIX = "WRITE DENIED, FILE UNMODIFIED:";
  */
 export const EDIT_FAILED_NOTE_PREFIX = "EDIT FAILED - file was NOT modified.";
 
+/**
+ * Common note fragments for DRY error messages
+ */
+export const NOTE_READ_FILE_RETRY = "Read the file to get current content, then retry.";
+export const NOTE_READ_FILE_FIRST_RETRY =
+  "Read the file first to get the exact current content, then retry.";
+export const NOTE_READ_FILE_AGAIN_RETRY = "Read the file again and retry.";
+
+/**
+ * Tool description warning for file edit tools
+ */
+export const TOOL_EDIT_WARNING =
+  "Always check the tool result before proceeding with other operations.";
+
 export type FileEditToolArgs =
   | FileEditReplaceStringToolArgs
   | FileEditReplaceLinesToolArgs

src/utils/tools/toolDefinitions.ts

@@ -12,6 +12,7 @@ import {
   BASH_MAX_LINE_BYTES,
   BASH_MAX_TOTAL_BYTES,
 } from "@/constants/toolLimits";
+import { TOOL_EDIT_WARNING } from "@/types/tools";
 
 import { zodToJsonSchema } from "zod-to-json-schema";
 
@@ -69,7 +70,7 @@ export const TOOL_DEFINITIONS = {
   file_edit_replace_string: {
     description:
       "Apply one or more edits to a file by replacing exact text matches. All edits are applied sequentially. Each old_string must be unique in the file unless replace_count > 1 or replace_count is -1. " +
-      "IMPORTANT: Edits may fail if old_string is not found or not unique. Always check the tool result before proceeding with other operations.",
+      `IMPORTANT: Edits may fail if old_string is not found or not unique. ${TOOL_EDIT_WARNING}`,
     schema: z.object({
       file_path: z.string().describe("The absolute path to the file to edit"),
       old_string: z
@@ -90,7 +91,7 @@ export const TOOL_DEFINITIONS = {
   file_edit_replace_lines: {
     description:
       "Replace a range of lines in a file. Use this for line-based edits when you know the exact line numbers to modify. " +
-      "IMPORTANT: Edits may fail if line numbers are invalid or file content has changed. Always check the tool result before proceeding with other operations.",
+      `IMPORTANT: Edits may fail if line numbers are invalid or file content has changed. ${TOOL_EDIT_WARNING}`,
     schema: z.object({
       file_path: z.string().describe("The absolute path to the file to edit"),
       start_line: z.number().int().min(1).describe("1-indexed start line (inclusive) to replace"),
@@ -109,7 +110,7 @@ export const TOOL_DEFINITIONS = {
   file_edit_insert: {
     description:
       "Insert content at a specific line position in a file. Line offset is 1-indexed: 0 inserts at the top, 1 inserts after line 1, etc. " +
-      "IMPORTANT: Edits may fail if line_offset is invalid or file doesn't exist. Always check the tool result before proceeding with other operations.",
+      `IMPORTANT: Edits may fail if line_offset is invalid or file doesn't exist. ${TOOL_EDIT_WARNING}`,
     schema: z.object({
       file_path: z.string().describe("The absolute path to the file to edit"),
       line_offset: z