Skip to content

🤖 fix: restore pre-redesign sidebar hierarchy#3121

Open
ammar-agent wants to merge 1 commit intomainfrom
revert-left-sidebar-redesign
Open

🤖 fix: restore pre-redesign sidebar hierarchy#3121
ammar-agent wants to merge 1 commit intomainfrom
revert-left-sidebar-redesign

Conversation

@ammar-agent
Copy link
Copy Markdown
Collaborator

Summary

Restore the flatter pre-redesign left sidebar hierarchy so project rows, sub-folder headers, and recency buckets read as distinct UI concepts again.

Background

The recent sidebar redesign made the tree read more like a nested folder explorer. In practice that made labels like "Older than 1 day" feel like another branch in the hierarchy instead of a recency bucket, which was confusing when scanning the sidebar.

Implementation

  • restored the older chevron-first project and multi-project row presentation instead of the newer folder-node treatment
  • brought back the older section header visual treatment so sub-folders stay visually distinct from projects and recency buckets
  • restored the inline add-section entry point and older row spacing for workspace, draft, and task-group rows so the hierarchy reads flatter again
  • restyled the "Older than …" buckets to behave like dividers/filter buckets rather than another nested tree node
  • kept newer non-visual behavior that still matters, including project menu actions, section auto-edit flows, and other follow-up logic layered on top of the redesign

Validation

  • make static-check
  • bun test src/browser/components/SectionHeader/SectionHeader.test.tsx
  • bun test src/browser/components/AgentListItem/AgentListItem.test.tsx
  • bun test ./tests/ui/chat/sections.test.ts
  • bun test ./tests/ui/workspaces/fork.test.ts
  • attempted bun test ./src/browser/components/ProjectSidebar/ProjectSidebar.test.tsx, but the local Bun runner currently errors before the test body executes while importing provider SVG ?react modules

Risks

Low to medium. This is intentionally a presentation-focused rollback in the sidebar, but it does touch indentation and grouping across project, section, draft, and task-group rows.


Generated with mux • Model: openai:gpt-5.4 • Thinking: xhigh • Cost: n/a

@ammar-agent
Copy link
Copy Markdown
Collaborator Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a84e846bd8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ammar-agent ammar-agent force-pushed the revert-left-sidebar-redesign branch from a84e846 to 5c3ae14 Compare April 4, 2026 16:37
@ammar-agent
Copy link
Copy Markdown
Collaborator Author

@codex review

Please take another look.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ammar-agent ammar-agent force-pushed the revert-left-sidebar-redesign branch from 5c3ae14 to 6e71e84 Compare April 4, 2026 17:47
@ammar-agent
Copy link
Copy Markdown
Collaborator Author

@codex review

Please take another look.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6e71e84531

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ammar-agent ammar-agent force-pushed the revert-left-sidebar-redesign branch from 6e71e84 to e3b7e96 Compare April 4, 2026 17:54
@ammar-agent
Copy link
Copy Markdown
Collaborator Author

@codex review

Please take another look.

@ammar-agent ammar-agent force-pushed the revert-left-sidebar-redesign branch from e3b7e96 to 9c2808a Compare April 4, 2026 18:01
@ammar-agent
Copy link
Copy Markdown
Collaborator Author

@codex review

Please take another look.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c2808a609

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ammar-agent ammar-agent force-pushed the revert-left-sidebar-redesign branch from 9c2808a to 1f591c8 Compare April 4, 2026 18:08
@ammar-agent
Copy link
Copy Markdown
Collaborator Author

@codex review

Please take another look.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ammar-agent ammar-agent force-pushed the revert-left-sidebar-redesign branch from 1f591c8 to 1a4e888 Compare April 5, 2026 14:57
@ammar-agent
Copy link
Copy Markdown
Collaborator Author

@codex review

Please take another look.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a4e888938

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ammar-agent ammar-agent force-pushed the revert-left-sidebar-redesign branch from 1a4e888 to 01486be Compare April 5, 2026 15:10
@ammar-agent
Copy link
Copy Markdown
Collaborator Author

@codex review

Please take another look.

@ammar-agent ammar-agent force-pushed the revert-left-sidebar-redesign branch from 01486be to 651520a Compare April 5, 2026 15:15
@ammar-agent
Copy link
Copy Markdown
Collaborator Author

@codex review

Please take another look.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ammar-agent ammar-agent force-pushed the revert-left-sidebar-redesign branch from 651520a to 72ed2cc Compare April 5, 2026 16:02
@ammar-agent
Copy link
Copy Markdown
Collaborator Author

@codex review

I tracked down another sidebar width regression: the compact inline action buttons were still inheriting the global 44px coarse-pointer minimum, and hidden touch-only workspace actions were reserving row width even while invisible. This patch keeps those inline sidebar controls compact again so the project/workspace actions stay inside the sidebar width.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 72ed2ccb10

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Restore the flatter sidebar hierarchy so project rows, section headers, and
"Older than …" buckets read as distinct layers again.

---

_Generated with `mux` • Model: `openai:gpt-5.4` • Thinking: `xhigh` • Cost: `n/a`_

<!-- mux-attribution: model=openai:gpt-5.4 thinking=xhigh costs=n/a -->
@ammar-agent ammar-agent force-pushed the revert-left-sidebar-redesign branch from 72ed2cc to a68d84f Compare April 5, 2026 16:15
@ammar-agent
Copy link
Copy Markdown
Collaborator Author

@codex review

I tightened the sidebar touch fix one more step: the same wide-touch helper that makes hidden inline buttons visible again now also restores pointer events, so quick archive stays tappable on tablets/large touch screens.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant