🤖 refactor: clean up workspace status handoff rendering#3136
🤖 refactor: clean up workspace status handoff rendering#3136ammar-agent wants to merge 1 commit intomainfrom
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e5094def01
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/browser/components/WorkspaceStatusIndicator/WorkspaceStatusIndicator.tsx
Show resolved
Hide resolved
ammar-agent
force-pushed
the
workspace-status-indicator-cleanup
branch
from
e5094de to
58157b3
Compare
|
@codex review Please take another look. |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Remove the mirrored timeout from the sidebar handoff slot, clear the transient collapse state when another status row hides the slot, and fold the related spec back down so the follow-up diff stays net negative. --- _Generated with `mux` • Model: `openai:gpt-5.4` • Thinking: `xhigh` • Cost: `$19.05`_ <!-- mux-attribution: model=openai:gpt-5.4 thinking=xhigh costs=19.05 -->
ammar-agent
force-pushed
the
workspace-status-indicator-cleanup
branch
from
58157b3 to
a0da41f
Compare
|
@codex review Please take another look. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
This follow-up to #3132 cleans up the workspace status indicator handoff without changing the behavior of the merged fix. It removes the mirrored JavaScript timeout used to retire the transient spinner slot, clears stale collapse state when another status row hides the slot first, and keeps the overall follow-up diff net negative.
Background
#3132 intentionally kept a temporary phase slot alive so the model label would not jump left when the sidebar moved from
startinginto live streaming. That fix worked, but the cleanup path still depended on a hard-coded timeout that duplicated the CSS transition duration. It also needed a guard so other status rows could hide the transient slot without leaving stale collapse state behind.Implementation
onTransitionEndso the component stops guessing when the CSS collapse finishedagentStatusor other blocking status UI hides the slot before any transition event can fire115insertions /122deletions)Validation
bun test ./src/browser/components/WorkspaceStatusIndicator/WorkspaceStatusIndicator.test.tsxbun test ./src/browser/stores/WorkspaceStore.test.ts --filter "stream starting state"bun test ./src/browser/components/AgentListItem/AgentListItem.test.tsxmake static-checkRisks
Low. This only touches the sidebar status indicator's transient start-to-stream cleanup path and its tests; the pending-model label behavior from #3132 stays intact.
Generated with
mux• Model:openai:gpt-5.4• Thinking:xhigh• Cost:$19.05