🤖 refactor: auto-cleanup

[mux-bot]

Summary

Long-lived auto-cleanup PR that accumulates low-risk, behavior-preserving refactors picked from recent main commits.

Changes

Drop redundant GuardAnchors type alias in file_edit_insert

In src/node/services/tools/file_edit_insert.ts, GuardAnchors was defined as Pick<InsertContentOptions, "insert_before" | "insert_after">, but InsertContentOptions itself is already Pick<FileEditInsertToolArgs, "insert_before" | "insert_after"> after the .nullish() strict-mode refactor in #2250 stripped the InsertContentOptions interface down to those same two fields. The two aliases became structurally identical, so GuardAnchors is dead.

Drop the alias and use InsertContentOptions for the two callers (insertWithGuards, resolveGuardAnchor). Both names were file-local; no exports change. The function names already convey "guard" context, so the parameter type doesn't need to repeat it. This noise was especially visible to the new guardless-empty-file path added in #3220 since it sits next to insertContent which uses InsertContentOptions.

Pure type-level cleanup — emitted JS, runtime behavior, and the public tool surface are all unchanged.

Previous cleanups

Extract ResolvedWorkspaceAiSettings type alias in taskService

The shape { model: string; thinkingLevel?: ThinkingLevel } (used internally to read per-agent AI settings off partial workspace metadata) was duplicated 7 times across the parameter and return types of resolveWorkspaceAISettings, resolveTaskAISettings, and resolveParentAutoResumeOptions in src/node/services/taskService.ts. The new sub-agent defaults split (#3215) made this duplication especially visible because it added a third method copying the same inline shape.

A private ResolvedWorkspaceAiSettings interface at module scope replaces all 7 inline occurrences. Pure type-level cleanup — emitted JS, runtime behavior, and the schema-derived WorkspaceAISettings type (where thinkingLevel is required) are all unchanged. The new interface is intentionally local to this file (not exported) since it captures the looser internal-reader shape, distinct from the canonical schema-derived type.

Extract shared ServiceTier type from ServiceTierSchema

The OpenAI service-tier literal union ("auto" | "default" | "flex" | "priority") was duplicated in three places: the CLI options interface (src/cli/run.ts), the providerModelFactory cast at the providers.jsonc boundary (src/node/services/providerModelFactory.ts), and a local OpenAIServiceTier alias in ProvidersSection.tsx. ServiceTierSchema (src/common/config/schemas/providersConfig.ts) already defines the same enum as the runtime source of truth, so this change derives a TypeScript ServiceTier alias via z.infer once and imports it at each site.

The Settings UI keeps its OpenAIServiceTier local alias (used by OpenAIServiceTierSelectValue and the isOpenAIServiceTier type guard) but it is now type OpenAIServiceTier = ServiceTier, so the disambiguating name and call sites stay intact.

Drop unused appendSpace literals on skill/model alias suggestions

In src/browser/utils/slashCommands/suggestions.ts, the SuggestionDefinition literals built for agent skills and model alias one-shots set appendSpace: true, but the build callbacks for those two paths hardcode the trailing space and never read definition.appendSpace. Only the top-level command and subcommand build callbacks consult the field. Remove the no-op appendSpace: true from the skill and model alias mappings and leave a short comment near each so a future reader doesn't assume the field is consulted on these paths.

Behavior is preserved — the field is unread on these paths, and the existing suggestions.test.ts / inlineSkillSuggestions.test.ts / suggestionMatching.test.ts suites all still pass.

Route ThemeContext color-scheme through isLightThemeMode

Replace the inline theme === "light" || theme === "flexoki-light" check in getColorScheme (in src/browser/contexts/ThemeContext.tsx) with the shared isLightThemeMode helper from src/browser/utils/highlighting/shiki-shared.ts.

The helper was just introduced as the single source of truth for the -light suffix → light-theme mapping, and the highlighting call sites (MarkdownComponents, HighlightedCode, highlightDiffChunk) already use it. This change extends that convention to ThemeContext so a future palette like solarized-light would automatically map to colorScheme: "light" without revisiting this site.

Behavior is preserved: for the four valid ThemeMode values ("light", "dark", "flexoki-light", "flexoki-dark"), isLightThemeMode returns the same result as the previous explicit comparison.

Validation

• bun test src/node/services/tools/file_edit_insert.test.ts — 16/16 pass.
• make static-check — eslint, tsgo (×2), prettier all pass; only shfmt fails because the binary is unavailable in this environment, and no shell files are touched.

Risks

Minimal — purely a TypeScript type alias removal local to one file. The emitted JS is unchanged, no exported types or APIs are touched, and InsertContentOptions is structurally identical to the removed GuardAnchors (both Pick the same two fields from FileEditInsertToolArgs).

---

Auto-cleanup checkpoint: af4912e

---

Generated with mux • Model: anthropic:claude-opus-4-7 • Thinking: xhigh

[mux-bot]

⚠️ Auto-fixup could not resolve CI failure: flaky tests, not caused by the cleanup commit.

Failed job: Test / Integration (run 25244368462)

Failures (both in tests/ui/compaction/compaction.test.ts):

1. force compaction triggers during streaming — timed out at 120000 ms waiting for "Compaction boundary" transcript text.
2. /compact with Ctrl+Enter (turn-end) does NOT auto-background foreground bash — waitFor in tests/ui/helpers.ts:144 could not locate the workspace in the sidebar.

What I checked:

• The PR diff is type-only refactors (extract ResolvedWorkspaceAiSettings / ServiceTier aliases, drop unused GuardAnchors / appendSpace literals, route ThemeContext color-scheme through isLightThemeMode). None of it touches compaction, streaming, the workspace consumer manager, or the test harness.
• Ran both failing tests locally on 1312f5a68:
  • force compaction triggers during streaming → PASS in 6.7s.
  • /compact with Ctrl+Enter ... → PASS in 4.7s.
• The streaming-compaction test has a 120s budget and clearly hit a slow/contended runner; the workspace-not-found timeout looks like the usual sidebar race in the harness.

No fix pushed. A re-run of Test / Integration should clear it; if it recurs on this PR or others, the test harness itself likely needs a stability pass (separate from this cleanup PR).