🤖 fix: add compact bash summary mode#3349
Conversation
|
@codex review
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df517cb8e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibetitsmike
force-pushed
the
mike/chat-tool-command-labels
branch
from
df517cb to
80a9a57
Compare
|
@codex review Addressed the attached leading redirection parsing feedback and added coverage for
|
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ibetitsmike
force-pushed
the
mike/chat-tool-command-labels
branch
from
80a9a57 to
232b055
Compare
|
@codex review Updated the command-label spacing after visual validation so comma-separated labels render more compactly in mono text.
|
ibetitsmike
force-pushed
the
mike/chat-tool-command-labels
branch
from
232b055 to
307953a
Compare
|
@codex review Updated the attribution and spacing-only diff on the latest SHA. Please review this head.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 307953a8c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibetitsmike
force-pushed
the
mike/chat-tool-command-labels
branch
from
307953a to
77cd0d3
Compare
|
@codex review Addressed the heredoc parser feedback by skipping heredoc bodies before command extraction, added coverage for quoted and tab-stripping heredocs, and kept the visual spacing fix.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77cd0d367d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibetitsmike
force-pushed
the
mike/chat-tool-command-labels
branch
from
77cd0d3 to
1617728
Compare
|
@codex review Addressed the arithmetic bit-shift feedback by skipping arithmetic expressions while scanning for heredocs and added coverage for
|
|
@codex review Please review the latest head after the arithmetic bit-shift fix.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1617728eaa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibetitsmike
force-pushed
the
mike/chat-tool-command-labels
branch
from
1617728 to
a9fd5c8
Compare
|
@codex review Addressed the
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9fd5c8839
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibetitsmike
force-pushed
the
mike/chat-tool-command-labels
branch
from
a9fd5c8 to
15ff82d
Compare
|
@codex review Addressed the noclobber redirection and brace group feedback, with coverage for
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15ff82d95f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibetitsmike
force-pushed
the
mike/chat-tool-command-labels
branch
from
15ff82d to
9940fdf
Compare
|
@codex review Addressed the subshell grouping feedback by stripping grouping delimiters before command-name normalization, with coverage for
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9940fdfa34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibetitsmike
force-pushed
the
mike/chat-tool-command-labels
branch
from
9940fdf to
632e195
Compare
|
@codex review Addressed the wrapper-flag feedback by skipping simple wrapper options before command extraction, with coverage for
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 632e1951c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibetitsmike
force-pushed
the
mike/chat-tool-command-labels
branch
from
632e195 to
9784939
Compare
|
@codex review Addressed the case-arm feedback by skipping case labels before command extraction, including
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e1c414206
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Addressed the variable-backed case-label feedback by treating
|
|
@codex review The latest head is
|
|
@codex review
|
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ibetitsmike
force-pushed
the
mike/chat-tool-command-labels
branch
from
e9cd63d to
0465151
Compare
ibetitsmike
changed the title
|
@codex review Rebased the branch onto latest main and changed the feature into a separate
|
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ibetitsmike
force-pushed
the
mike/chat-tool-command-labels
branch
from
0465151 to
00f5407
Compare
|
@codex review Updated the branch with a focused CI test mock hardening after the unit job exposed a partial
|
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9cccd6340e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review
|
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review
|
---
_Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `3738256{MUX_COSTS_USD:-unknown}`_
<!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=190.47 -->
Keep browser global overrides scoped to each keybind test so later unit tests keep their expected DOM and event APIs. --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `$223.75`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=223.75 -->
Treat the shell negation operator as prefix syntax so compact command extraction shows the command that runs instead of `!`. --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `$223.75`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=223.75 -->
Keep test-only window and runtime factory overrides from leaking into later unit files during full suite runs. --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `$223.75`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=223.75 -->
Extract shared browser test helpers for window and navigator mocking, then use them in GitStatusStore and keybind tests to remove duplicate descriptor cleanup logic. --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `$223.75`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=223.75 -->
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ibetitsmike
force-pushed
the
mike/chat-tool-command-labels
branch
from
cea59b2 to
bd406de
Compare
|
@codex review
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd406deb19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Stop heredoc detection at unquoted shell comments so compact command extraction does not hide real commands after commented heredoc syntax. --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `$223.75`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=223.75 -->
|
@codex review
|
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Rebases the bash header work onto latest
mainand adds a new collapsed bash summary setting:Compact. The defaultIntent and commandmode keeps main's stacked intent plus raw command layout,Commandkeeps the raw command-only mode, andCompactshows only parsed command names likecd, git.Implementation
Intent and command,Compact, andCommand.BashToolCallthat omits intent, raw script text, and command metadata so the row stays minimal.Validation
bun test src/browser/features/Tools/bashCollapsedSummary.test.ts src/browser/features/Settings/Sections/GeneralSection.test.tsxbun test src/browser/features/Tools/bashCollapsedSummary.test.tsbun test src/browser/stores/GitStatusStore.test.tsbun test src/browser/utils/ui/keybinds.test.ts src/browser/utils/commands/sources.test.tsbun test src/browser/utils/ui/keybinds.test.ts src/browser/components/WorkspaceHeartbeatModal/WorkspaceHeartbeatModal.test.tsx src/browser/features/Messages/InlineSkillMarkdown.test.tsx src/node/services/tools/task_apply_git_patch.test.tsbun test src/browser/utils/ui/keybinds.test.ts src/browser/stores/GitStatusStore.test.ts src/node/services/utils/forkOrchestrator.multiProject.test.ts src/node/services/tools/task_apply_git_patch.test.tsTEST_INTEGRATION=1 bun x jest tests/ui/review/undo.test.ts tests/ui/chat/sendModeDropdown.test.ts --runInBandbun test srcmake static-checkRisks
Low. This only changes collapsed bash header display and test-only mock cleanup. The expanded Script section still shows the full command.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$223.75