Skip to content

Commit 186a779

Browse files
authored
chore(registry/coder/modules): rename vscode-desktop-core input params (#750)
## Description Rename `web_app_*` suffix to `coder_app_*` ## Type of Change - [ ] New module - [ ] New template - [ ] Bug fix - [x] Feature/enhancement - [ ] Documentation - [ ] Other
1 parent 8defcb2 commit 186a779

3 files changed

Lines changed: 23 additions & 23 deletions

File tree

registry/coder/modules/vscode-desktop-core/README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,15 @@ The VSCode Desktop Core module is a building block for modules that need to expo
1616
```tf
1717
module "vscode-desktop-core" {
1818
source = "registry.coder.com/coder/vscode-desktop-core/coder"
19-
version = "1.0.1"
19+
version = "1.0.2"
2020
2121
agent_id = var.agent_id
2222
23-
web_app_icon = "/icon/code.svg"
24-
web_app_slug = "vscode"
25-
web_app_display_name = "VS Code Desktop"
26-
web_app_order = var.order
27-
web_app_group = var.group
23+
coder_app_icon = "/icon/code.svg"
24+
coder_app_slug = "vscode"
25+
coder_app_display_name = "VS Code Desktop"
26+
coder_app_order = var.order
27+
coder_app_group = var.group
2828
2929
folder = var.folder
3030
open_recent = var.open_recent

registry/coder/modules/vscode-desktop-core/main.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ const appName = "vscode-desktop";
1111
const defaultVariables = {
1212
agent_id: "foo",
1313

14-
web_app_icon: "/icon/code.svg",
15-
web_app_slug: "vscode",
16-
web_app_display_name: "VS Code Desktop",
14+
coder_app_icon: "/icon/code.svg",
15+
coder_app_slug: "vscode",
16+
coder_app_display_name: "VS Code Desktop",
1717

1818
protocol: "vscode",
1919
};
@@ -99,16 +99,16 @@ describe("vscode-desktop-core", async () => {
9999
);
100100

101101
expect(coder_app?.instances[0].attributes.slug).toBe(
102-
defaultVariables.web_app_slug,
102+
defaultVariables.coder_app_slug,
103103
);
104104
expect(coder_app?.instances[0].attributes.display_name).toBe(
105-
defaultVariables.web_app_display_name,
105+
defaultVariables.coder_app_display_name,
106106
);
107107
});
108108

109109
it("sets order", async () => {
110110
const state = await runTerraformApply(import.meta.dir, {
111-
web_app_order: "5",
111+
coder_app_order: "5",
112112

113113
...defaultVariables,
114114
});
@@ -122,7 +122,7 @@ describe("vscode-desktop-core", async () => {
122122

123123
it("sets group", async () => {
124124
const state = await runTerraformApply(import.meta.dir, {
125-
web_app_group: "web-app-group",
125+
coder_app_group: "web-app-group",
126126

127127
...defaultVariables,
128128
});

registry/coder/modules/vscode-desktop-core/main.tf

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,28 +31,28 @@ variable "protocol" {
3131
description = "The URI protocol the IDE."
3232
}
3333

34-
variable "web_app_icon" {
34+
variable "coder_app_icon" {
3535
type = string
3636
description = "The icon of the coder_app."
3737
}
3838

39-
variable "web_app_slug" {
39+
variable "coder_app_slug" {
4040
type = string
4141
description = "The slug of the coder_app."
4242
}
4343

44-
variable "web_app_display_name" {
44+
variable "coder_app_display_name" {
4545
type = string
4646
description = "The display name of the coder_app."
4747
}
4848

49-
variable "web_app_order" {
49+
variable "coder_app_order" {
5050
type = number
5151
description = "The order of the coder_app."
5252
default = null
5353
}
5454

55-
variable "web_app_group" {
55+
variable "coder_app_group" {
5656
type = string
5757
description = "The group of the coder_app."
5858
default = null
@@ -65,12 +65,12 @@ resource "coder_app" "vscode-desktop" {
6565
agent_id = var.agent_id
6666
external = true
6767

68-
icon = var.web_app_icon
69-
slug = var.web_app_slug
70-
display_name = var.web_app_display_name
68+
icon = var.coder_app_icon
69+
slug = var.coder_app_slug
70+
display_name = var.coder_app_display_name
7171

72-
order = var.web_app_order
73-
group = var.web_app_group
72+
order = var.coder_app_order
73+
group = var.coder_app_group
7474

7575
url = join("", [
7676
var.protocol,

0 commit comments

Comments
 (0)