feat: add healthcheck and config options to JupyterLab Module#363
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds health check functionality and automatic CSP configuration to the JupyterLab module to simplify setup for iframe embedding in Coder workspaces.
- Added automatic Content-Security-Policy fallback configuration when no custom config is provided
- Added health check endpoint monitoring for the JupyterLab service
- Introduced configurable JupyterLab server settings through a new
configvariable
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| registry/coder/modules/jupyterlab/main.tf | Added locals for CSP fallback config, new config variable, config script resource, and healthcheck block |
| registry/coder/modules/jupyterlab/main.test.ts | Added test coverage for config file creation and validation of empty config behavior |
| registry/coder/modules/jupyterlab/README.md | Updated documentation with configuration examples and CSP requirements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
❌ Version Bump Validation FailedBump Type: Module versions need to be updated but haven't been bumped yet. Required Actions:
Script Output:
|
matifali
approved these changes
Aug 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplified JupyterLab module configuration and added automatic CSP headers for iFrame embedding for Coder Tasks. The module now works out of the box without requiring users to manually configure Content-Security-Policy headers.
Changes:
Type of Change
Module Information
Path:
registry/coder/modules/jupyterlabNew version:
v1.2.0Breaking change: [x] Yes [ ] No
Breaking change: Config behavior changed - now automatically includes CSP when no user config provided
Testing & Validation
bun test)bun run fmt)Related Issues
Closes #345