Skip to content

ci: remove branch filter to support stacked PRs#786

Merged
matifali merged 1 commit intomainfrom
ssncf/ci-stacked-prs
Mar 5, 2026
Merged

ci: remove branch filter to support stacked PRs#786
matifali merged 1 commit intomainfrom
ssncf/ci-stacked-prs

Conversation

@ssncferreira
Copy link
Copy Markdown
Contributor

@ssncferreira ssncferreira commented Mar 5, 2026

Description

Remove branches: [main] filter from the CI workflow so it triggers on PRs targeting any branch, not just main. This enables CI to run on stacked PRs (where the base branch is another PR branch, not main).

This matches the approach used in coder/coder.

Type of Change

  • New module
  • New template
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Related to internal Slack thread: https://codercom.slack.com/archives/C08PHACTZRB/p1772702628637129?thread_ts=1772538788.281829&cid=C08PHACTZRB

@ssncferreira ssncferreira marked this pull request as ready for review March 5, 2026 09:53
@ssncferreira ssncferreira requested a review from matifali March 5, 2026 09:53
@matifali matifali merged commit f6a09d4 into main Mar 5, 2026
6 checks passed
@matifali matifali deleted the ssncf/ci-stacked-prs branch March 5, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants