feat(devcontainer): add optional name attribute to prevent sub-agent name collisions#519
Open
mmustafasenoglu wants to merge 1 commit into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
af22e85 to
327caa3
Compare
…name collisions When using for_each or count with coder_devcontainer, all instances share the same Terraform block name, causing sub-agent name collisions. This change adds an optional 'name' attribute that allows overriding the sub-agent name. When set, this name takes precedence over the Terraform block name. Fixes coder#503
327caa3 to
987edd9
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
Author
|
Hi maintainers! I've signed the CLA by commenting 'I have read the CLA Document and I hereby sign the CLA' but the CLA Assistant check is still failing. Could you please manually approve the CLA or re-trigger the CLA check? The PR adds an optional attribute to to prevent sub-agent name collisions when using / (fixes #503). Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
for_eachorcountwithcoder_devcontainer, all instances share the same Terraform block name, causing sub-agent name collisions:Fix
Added an optional
nameattribute to thecoder_devcontainerresource schema. When set, this name takes precedence over the Terraform block name when constructing the sub-agent name.Testing
Added
TestDevcontainerWithNametest case verifying the new attribute is properly stored.Note: Server-side changes in
coder/coderare also needed to read and use thisnameattribute when constructing theproto.Devcontainer.Fixes #503