feat: add use_classic_parameter_flow to coderd_template resource#251
Merged
Conversation
ethanndickson
commented
Aug 18, 2025
Comment on lines
-704
to
-708
| // TODO(ethanndickson): Remove this once the provider requires a Coder | ||
| // deployment running `v2.15.0` or later. | ||
| if newState.MaxPortShareLevel.IsUnknown() { | ||
| newState.MaxPortShareLevel = curState.MaxPortShareLevel | ||
| } |
Member
Author
There was a problem hiding this comment.
Removed this because I realised I could use planmodifier UseStateForUnknown for it.
Comment on lines
+605
to
+606
| // TODO: Remove this update call (and the attribute) once the provider | ||
| // requires a Coder version where this flag has been removed. |
Member
Author
There was a problem hiding this comment.
Coder 2.24 does not include the bool on CreateTemplateRequest, only on UpdateTemplateMeta. 2.25 does include it on CreateTemplateRequest, however.
aslilac
approved these changes
Aug 18, 2025
Member
aslilac
left a comment
aslilac
left a comment
There was a problem hiding this comment.
one small clerical suggestion, but the code looks great!
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #240.
By popular demand, this exposes the fallback to classic parameters via the Template resource.