Skip to content

Commit 0467501

Browse files
committed
fix: remove scroll-to-bottom round-trip from chat embed
1 parent 1b5b432 commit 0467501

File tree

2 files changed

+0
-20
lines changed

2 files changed

+0
-20
lines changed

src/webviews/chat/chatPanelProvider.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,6 @@ export class ChatPanelProvider
4141
: "dark";
4242
}
4343

44-
private sendScrollToBottom(): void {
45-
this.view?.webview.postMessage({ type: "coder:scroll-to-bottom" });
46-
}
47-
4844
private sendTheme(): void {
4945
this.view?.webview.postMessage({
5046
type: "coder:set-theme",
@@ -129,7 +125,6 @@ export class ChatPanelProvider
129125
break;
130126
case "coder:chat-ready":
131127
this.sendTheme();
132-
this.sendScrollToBottom();
133128
break;
134129
case "coder:navigate": {
135130
const url = msg.payload?.url;
@@ -284,11 +279,6 @@ export class ChatPanelProvider
284279
}, '${allowedOrigin}');
285280
}
286281
287-
if (data.type === 'coder:scroll-to-bottom') {
288-
iframe.contentWindow.postMessage(
289-
{ type: 'coder:scroll-to-bottom' }, '${allowedOrigin}');
290-
}
291-
292282
if (data.type === 'coder:auth-error') {
293283
status.textContent = '';
294284
status.appendChild(document.createTextNode(data.error || 'Authentication failed.'));

test/unit/webviews/chat/chatPanelProvider.test.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -100,16 +100,6 @@ describe("ChatPanelProvider", () => {
100100
});
101101
});
102102

103-
it("sends scroll-to-bottom on chat-ready", () => {
104-
const { sendFromWebview, postMessage } = createHarness();
105-
106-
sendFromWebview({ type: "coder:chat-ready" });
107-
108-
expect(findPostedMessage(postMessage, "coder:scroll-to-bottom")).toEqual({
109-
type: "coder:scroll-to-bottom",
110-
});
111-
});
112-
113103
it("sends theme when VS Code theme changes", () => {
114104
const { postMessage } = createHarness();
115105
postMessage.mockClear();

0 commit comments

Comments
 (0)