fix: remove eager WebSocket reconnect on SSH PID change

Server-side heartbeat (15s ping) already handles dead connections.
WebSockets use a separate HTTPS path from the SSH tunnel, so PID
changes don't reliably indicate WebSocket issues.

Author: EhabY

CHANGELOG.md

@@ -4,8 +4,8 @@
 
 ### Fixed
 
-- SSH connections now recover faster after laptop sleep/wake by detecting port changes,
-  re-registering the label formatter, and refreshing WebSockets automatically.
+- SSH connections now recover faster after laptop sleep/wake by detecting port changes
+  and re-registering the label formatter.
 - SSH process discovery now uses `ss` -> `netstat` -> `lsof` on Linux
   and `netstat` -> `lsof` on macOS, fixing systems where `netstat` was unavailable
   and the SSH PID could not be resolved, which broke network info display and log viewing.

src/api/coderApi.ts

@@ -154,23 +154,6 @@ export class CoderApi extends Api implements vscode.Disposable {
 		this.setCredentials(host, this.getSessionToken());
 	};
 
-	/**
-	 * Force-reconnect all sockets in CONNECTED state, which may be in a TCP
-	 * half-open state after sleep/wake. Sockets in other states (AWAITING_RETRY,
-	 * DISCONNECTED) are left alone as they already have their own retry logic.
-	 */
-	reconnectAllConnected(reason: string): void {
-		const stale = [...this.reconnectingSockets].filter(
-			(s) => s.state === ConnectionState.CONNECTED,
-		);
-		if (stale.length > 0) {
-			this.output.info(`Reconnecting ${stale.length} WebSocket(s): ${reason}`);
-			for (const socket of stale) {
-				socket.reconnect();
-			}
-		}
-	}
-
 	/**
 	 * Permanently dispose all WebSocket connections.
 	 * This clears handlers and prevents reconnection.

src/remote/remote.ts

@@ -529,8 +529,6 @@ export class Remote {
 				// Re-register label formatter when SSH process reconnects after sleep/wake
 				sshMonitor.onPidChange(() => {
 					reregisterLabelFormatter();
-					// Reconnect WebSockets that may be in TCP half-open state
-					workspaceClient.reconnectAllConnected("SSH process changed");
 				}),
 				// Register the label formatter again because SSH overrides it!
 				vscode.extensions.onDidChange(() => {

test/unit/api/coderApi.test.ts

@@ -795,44 +795,6 @@ describe("CoderApi", () => {
 		});
 	});
 
-	describe("reconnectAllConnected", () => {
-		const tick = () => new Promise((resolve) => setImmediate(resolve));
-
-		it("reconnects sockets in CONNECTED state", async () => {
-			const { sockets } = setupAutoOpeningWebSocket();
-			api = createApi(CODER_URL, AXIOS_TOKEN);
-			await api.watchAgentMetadata(AGENT_ID);
-			await tick();
-
-			api.reconnectAllConnected("sleep/wake recovery");
-			await tick();
-
-			expect(sockets[0].close).toHaveBeenCalledWith(
-				1000,
-				"Replacing connection",
-			);
-			expect(sockets).toHaveLength(2);
-		});
-
-		it.each([
-			["AWAITING_RETRY", 1006, "Abnormal closure"],
-			["DISCONNECTED", 1002, "Protocol error"],
-		])("does not reconnect %s sockets", async (_state, code, reason) => {
-			const { sockets, handlers } = setupAutoOpeningWebSocket();
-			api = createApi(CODER_URL, AXIOS_TOKEN);
-			await api.watchAgentMetadata(AGENT_ID);
-			await tick();
-
-			handlers["close"]?.({ code, reason });
-			await tick();
-
-			api.reconnectAllConnected("sleep/wake recovery");
-			await tick();
-
-			expect(sockets).toHaveLength(1);
-		});
-	});
-
 	describe("Configuration Change Reconnection", () => {
 		const tick = () => new Promise((resolve) => setImmediate(resolve));