chore: remove unnecessary vscodeProposed mocks from tests

The vscodeProposed proxy already falls back to the vscode module (which
is aliased to the test mock via vitest.config.ts), so explicitly mocking
it is redundant. Also adds disableUpdateNotifications re-enable test.

Author: EhabY

test/unit/core/binaryLock.test.ts

@@ -1,5 +1,4 @@
 import { beforeEach, describe, expect, it, vi } from "vitest";
-import * as vscode from "vscode";
 
 import { BinaryLock } from "@/core/binaryLock";
 import * as downloadProgress from "@/core/downloadProgress";
@@ -11,10 +10,6 @@ import {
 
 vi.mock("vscode");
 
-vi.mock("@/vscodeProposed", () => ({
-	vscodeProposed: vscode,
-}));
-
 // Mock proper-lockfile
 vi.mock("proper-lockfile", () => ({
 	lock: vi.fn(),

test/unit/core/cliManager.concurrent.test.ts

@@ -10,7 +10,6 @@ import * as fs from "node:fs/promises";
 import * as os from "node:os";
 import * as path from "node:path";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
-import * as vscode from "vscode";
 
 import { CliManager } from "@/core/cliManager";
 import * as cliUtils from "@/core/cliUtils";
@@ -27,10 +26,6 @@ import {
 
 vi.mock("@/pgp");
 
-vi.mock("@/vscodeProposed", () => ({
-	vscodeProposed: vscode,
-}));
-
 vi.mock("@/core/cliUtils", async () => {
 	const actual = await vi.importActual<typeof cliUtils>("@/core/cliUtils");
 	return {

test/unit/core/cliManager.test.ts

@@ -59,10 +59,6 @@ vi.mock("proper-lockfile", () => ({
 
 vi.mock("@/pgp");
 
-vi.mock("@/vscodeProposed", () => ({
-	vscodeProposed: vscode,
-}));
-
 vi.mock("@/core/cliUtils", async () => {
 	const actual =
 		await vi.importActual<typeof import("@/core/cliUtils")>("@/core/cliUtils");

test/unit/login/loginCoordinator.test.ts

@@ -67,10 +67,6 @@ vi.mock("@/promptUtils", () => ({
 	maybeAskUrl: vi.fn(),
 }));
 
-vi.mock("@/vscodeProposed", () => ({
-	vscodeProposed: vscode,
-}));
-
 // Mock CoderApi to control getAuthenticatedUser behavior
 const mockGetAuthenticatedUser = vi.hoisted(() => vi.fn());
 vi.mock("@/api/coderApi", async (importOriginal) => {

test/unit/uri/uriHandler.test.ts

@@ -21,10 +21,6 @@ import type { LoginCoordinator, LoginOptions } from "@/login/loginCoordinator";
 
 vi.mock("@/promptUtils", () => ({ maybeAskUrl: vi.fn() }));
 
-vi.mock("@/vscodeProposed", () => ({
-	vscodeProposed: vscode,
-}));
-
 const TEST_URL = "https://coder.example.com";
 const TEST_HOSTNAME = "coder.example.com";
 

test/unit/workspace/workspaceMonitor.test.ts

@@ -255,6 +255,24 @@ describe("WorkspaceMonitor", () => {
 			);
 			monitor.dispose();
 		});
+
+		it("shows outdated notification after re-enabling", async () => {
+			config.set("coder.disableUpdateNotifications", true);
+			const { monitor, stream, client } = await createMonitor();
+			monitor.markInitialSetupComplete();
+
+			stream.pushMessage(workspaceEvent(createWorkspace({ outdated: true })));
+			expect(client.getTemplate).not.toHaveBeenCalled();
+
+			config.set("coder.disableUpdateNotifications", false);
+
+			stream.pushMessage(workspaceEvent(createWorkspace({ outdated: true })));
+
+			await vi.waitFor(() => {
+				expect(client.getTemplate).toHaveBeenCalled();
+			});
+			monitor.dispose();
+		});
 	});
 
 	describe("disableNotifications", () => {