refactor: rename agentId param to chatId

Avoids confusion with the workspace agent param that the /open
deep link already accepts.

Author: ThomasK33

src/core/mementoManager.ts

@@ -59,26 +59,26 @@ export class MementoManager {
 	}
 
 	/**
-	 * Store a chat agent ID to open after a window reload.
+	 * Store a chat ID to open after a window reload.
 	 * Used by the /open deep link handler: it must call
 	 * commands.open() which triggers a remote-authority
-	 * reload, wiping in-memory state.  The agent ID is
+	 * reload, wiping in-memory state.  The chat ID is
 	 * persisted here so the extension can pick it up on
 	 * the other side of the reload.
 	 */
-	public async setPendingChatAgentId(agentId: string): Promise<void> {
-		await this.memento.update("pendingChatAgentId", agentId);
+	public async setPendingChatId(chatId: string): Promise<void> {
+		await this.memento.update("pendingChatId", chatId);
 	}
 
 	/**
-	 * Read and clear the pending chat agent ID.  Returns
+	 * Read and clear the pending chat ID.  Returns
 	 * undefined if none was stored.
 	 */
-	public async getAndClearPendingChatAgentId(): Promise<string | undefined> {
-		const agentId = this.memento.get<string>("pendingChatAgentId");
-		if (agentId !== undefined) {
-			await this.memento.update("pendingChatAgentId", undefined);
+	public async getAndClearPendingChatId(): Promise<string | undefined> {
+		const chatId = this.memento.get<string>("pendingChatId");
+		if (chatId !== undefined) {
+			await this.memento.update("pendingChatId", undefined);
 		}
-		return agentId;
+		return chatId;
 	}
 }

src/extension.ts

@@ -331,10 +331,9 @@ export async function activate(ctx: vscode.ExtensionContext): Promise<void> {
 				// If a deep link stored a chat agent ID before the
 				// remote-authority reload, open it now that the
 				// deployment is configured.
-				const pendingAgentId =
-					await mementoManager.getAndClearPendingChatAgentId();
-				if (pendingAgentId) {
-					chatPanelProvider.openChat(pendingAgentId);
+				const pendingChatId = await mementoManager.getAndClearPendingChatId();
+				if (pendingChatId) {
+					chatPanelProvider.openChat(pendingChatId);
 				}
 			}
 		} catch (ex) {

src/uri/uriHandler.ts

@@ -89,13 +89,13 @@ async function handleOpen(ctx: UriRouteContext): Promise<void> {
 		params.has("openRecent") &&
 		(!params.get("openRecent") || params.get("openRecent") === "true");
 
-	// Persist the chat agent ID before commands.open() triggers
+	// Persist the chat ID before commands.open() triggers
 	// a remote-authority reload that wipes in-memory state.
 	// The extension picks this up after the reload in activate().
-	const agentId = params.get("agentId");
-	if (agentId) {
+	const chatId = params.get("chatId");
+	if (chatId) {
 		const mementoManager = serviceContainer.getMementoManager();
-		await mementoManager.setPendingChatAgentId(agentId);
+		await mementoManager.setPendingChatId(chatId);
 	}
 
 	await setupDeployment(params, serviceContainer, deploymentManager);

src/webviews/chat/chatPanelProvider.ts

@@ -25,7 +25,7 @@ export class ChatPanelProvider
 
 	private view?: vscode.WebviewView;
 	private disposables: vscode.Disposable[] = [];
-	private agentId: string | undefined;
+	private chatId: string | undefined;
 
 	constructor(
 		private readonly client: CoderApi,
@@ -35,8 +35,8 @@ export class ChatPanelProvider
 	/**
 	 * Called by the `/openChat` URI handler.
 	 */
-	public openChat(agentId: string): void {
-		this.agentId = agentId;
+	public openChat(chatId: string): void {
+		this.chatId = chatId;
 		this.refresh();
 		void vscode.commands.executeCommand("coder.chatPanel.focus");
 	}
@@ -70,7 +70,7 @@ export class ChatPanelProvider
 		}
 		const webview = this.view.webview;
 
-		if (!this.agentId) {
+		if (!this.chatId) {
 			webview.html = this.getNoAgentHtml();
 			return;
 		}
@@ -81,7 +81,7 @@ export class ChatPanelProvider
 			return;
 		}
 
-		const embedUrl = `${coderUrl}/agents/${this.agentId}/embed`;
+		const embedUrl = `${coderUrl}/agents/${this.chatId}/embed`;
 		webview.html = this.getIframeHtml(embedUrl, coderUrl);
 	}