refactor: remove disposeInternals, use dispose directly

ThomasK33 · ThomasK33 · commit 7852f5b04d57 · 2026-03-17T18:40:16.000Z
diff --git a/src/webviews/chat/chatPanelProvider.ts b/src/webviews/chat/chatPanelProvider.ts
@@ -54,7 +54,7 @@ export class ChatPanelProvider
 			}),
 		);
 		this.renderView();
-		webviewView.onDidDispose(() => this.disposeInternals());
+		webviewView.onDidDispose(() => this.dispose());
 	}
 
 	public refresh(): void {
@@ -183,14 +183,10 @@ text-align:center;}</style></head>
 <body><p>No active chat session. Open a chat from the Agents tab on your Coder deployment.</p></body></html>`;
 	}
 
-	private disposeInternals(): void {
+	dispose(): void {
 		for (const d of this.disposables) {
 			d.dispose();
 		}
 		this.disposables = [];
 	}
-
-	dispose(): void {
-		this.disposeInternals();
-	}
 }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ export class ChatPanelProvider`
`54`	`54`	`}),`
`55`	`55`	`);`
`56`	`56`	`this.renderView();`
`57`		`- webviewView.onDidDispose(() => this.disposeInternals());`
	`57`	`+ webviewView.onDidDispose(() => this.dispose());`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`public refresh(): void {`
`@@ -183,14 +183,10 @@ text-align:center;}</style></head>`
`183`	`183`	<body><p>No active chat session. Open a chat from the Agents tab on your Coder deployment.</p></body></html>`;
`184`	`184`	`}`
`185`	`185`
`186`		`- private disposeInternals(): void {`
	`186`	`+ dispose(): void {`
`187`	`187`	`for (const d of this.disposables) {`
`188`	`188`	`d.dispose();`
`189`	`189`	`}`
`190`	`190`	`this.disposables = [];`
`191`	`191`	`}`
`192`		`-`
`193`		`- dispose(): void {`
`194`		`- this.disposeInternals();`
`195`		`- }`
`196`	`192`	`}`