refactor: apply telemetry review conventions

Make telemetry dimensions explicit at every call site: suspendSession
and clearDeployment now require a reason instead of defaulting (the
suspendSession default was never used in production), and
CliCredentialManager requires its TelemetryReporter rather than
silently falling back to the noop reporter.

Replace the scenario DSL in commands.telemetry.test.ts with plain it()
blocks on a shared setup() that reuses createTelemetryHarness, and drop
the unused clearDeploymentError option.

Author: EhabY

src/core/cliCredentialManager.ts

@@ -14,10 +14,7 @@ import {
 } from "../instrumentation/credentials";
 import { isKeyringEnabled } from "../settings/cli";
 import { getHeaderArgs } from "../settings/headers";
-import {
-	NOOP_TELEMETRY_REPORTER,
-	type TelemetryReporter,
-} from "../telemetry/reporter";
+import { type TelemetryReporter } from "../telemetry/reporter";
 import { toSafeHost } from "../util";
 import { writeAtomically } from "../util/fs";
 
@@ -62,7 +59,7 @@ export class CliCredentialManager {
 		private readonly logger: Logger,
 		private readonly resolveBinary: BinaryResolver,
 		private readonly pathResolver: PathResolver,
-		telemetry: TelemetryReporter = NOOP_TELEMETRY_REPORTER,
+		telemetry: TelemetryReporter,
 	) {
 		this.credentialTelemetry = new CredentialTelemetry(telemetry);
 	}

src/deployment/deploymentManager.ts

@@ -182,9 +182,7 @@ export class DeploymentManager implements vscode.Disposable {
 	/**
 	 * Clears the current deployment.
 	 */
-	public async clearDeployment(
-		reason: DeploymentSuspendReason = "credentials_removed",
-	): Promise<void> {
+	public async clearDeployment(reason: DeploymentSuspendReason): Promise<void> {
 		this.logger.debug("Clearing deployment", this.#deployment?.safeHostname);
 		this.suspendSession(reason);
 		this.#authListenerDisposable?.dispose();
@@ -199,9 +197,7 @@ export class DeploymentManager implements vscode.Disposable {
 	 * Suspend session: shows logged-out state but keeps deployment for easy re-login.
 	 * Auth listener remains active so recovery can happen automatically if tokens update.
 	 */
-	public suspendSession(
-		reason: DeploymentSuspendReason = "auth_config_change",
-	): void {
+	public suspendSession(reason: DeploymentSuspendReason): void {
 		const wasAuthenticated = this.isAuthenticated();
 		this.oauthSessionManager.clearDeployment();
 		this.client.setCredentials(undefined, undefined);
@@ -267,7 +263,7 @@ export class DeploymentManager implements vscode.Disposable {
 						);
 					}
 				} else {
-					await this.clearDeployment();
+					await this.clearDeployment("credentials_removed");
 				}
 			},
 		);