feat: fall back to extension storage for proxy log directory

When coder.proxyLogDirectory is not configured, use the extension's
global storage log path instead of discarding logs. This makes
troubleshooting easier without requiring manual configuration.

Author: EhabY

package.json

@@ -102,7 +102,7 @@
 					"default": ""
 				},
 				"coder.proxyLogDirectory": {
-					"markdownDescription": "If set, the Coder CLI will output extra SSH information into this directory, which can be helpful for debugging connectivity issues.",
+					"markdownDescription": "Directory where the Coder CLI outputs SSH connection logs for debugging. When not configured, logs are stored in the extension's global storage directory.",
 					"type": "string",
 					"default": ""
 				},

src/commands.ts

@@ -150,51 +150,33 @@ export class Commands {
 			return this.openFile(this.workspaceLogPath);
 		}
 
-		const logDir = vscode.workspace
-			.getConfiguration()
-			.get<string>("coder.proxyLogDirectory");
-		if (logDir) {
-			try {
-				const files = await fs.readdir(logDir);
-				// Sort explicitly since fs.readdir order is platform-dependent
-				const logFiles = files
-					.filter((f) => f.endsWith(".log"))
-					.sort((a, b) => a.localeCompare(b))
-					.reverse();
-
-				if (logFiles.length === 0) {
-					vscode.window.showInformationMessage(
-						"No log files found in the configured log directory.",
-					);
-					return;
-				}
+		const logDir = this.pathResolver.getProxyLogPath();
+		try {
+			const files = await fs.readdir(logDir);
+			// Sort explicitly since fs.readdir order is platform-dependent
+			const logFiles = files
+				.filter((f) => f.endsWith(".log"))
+				.sort((a, b) => a.localeCompare(b))
+				.reverse();
+
+			if (logFiles.length === 0) {
+				vscode.window.showInformationMessage(
+					"No log files found in the log directory.",
+				);
+				return;
+			}
 
-				const selected = await vscode.window.showQuickPick(logFiles, {
-					title: "Select a log file to view",
-				});
+			const selected = await vscode.window.showQuickPick(logFiles, {
+				title: "Select a log file to view",
+			});
 
-				if (selected) {
-					await this.openFile(path.join(logDir, selected));
-				}
-			} catch (error) {
-				vscode.window.showErrorMessage(
-					`Failed to read log directory: ${error instanceof Error ? error.message : String(error)}`,
-				);
+			if (selected) {
+				await this.openFile(path.join(logDir, selected));
 			}
-		} else {
-			vscode.window
-				.showInformationMessage(
-					"No logs available. Make sure to set coder.proxyLogDirectory to get logs.",
-					"Open Settings",
-				)
-				.then((action) => {
-					if (action === "Open Settings") {
-						vscode.commands.executeCommand(
-							"workbench.action.openSettings",
-							"coder.proxyLogDirectory",
-						);
-					}
-				});
+		} catch (error) {
+			vscode.window.showErrorMessage(
+				`Failed to read log directory: ${error instanceof Error ? error.message : String(error)}`,
+			);
 		}
 	}
 

src/core/pathResolver.ts

@@ -1,6 +1,8 @@
 import * as path from "node:path";
 import * as vscode from "vscode";
 
+import { expandPath } from "../util";
+
 export class PathResolver {
 	constructor(
 		private readonly basePath: string,
@@ -51,16 +53,28 @@ export class PathResolver {
 	}
 
 	/**
-	 * Return the path where log data from the connection is stored.
+	 * Return the default path where log data from the connection is stored.
 	 *
 	 * The CLI will write files here named after the process PID.
-	 *
-	 * Note: This directory is not currently used.
 	 */
 	public getLogPath(): string {
 		return path.join(this.basePath, "log");
 	}
 
+	/**
+	 * Return the proxy log directory from user settings, falling back to the
+	 * default log path in extension storage.
+	 */
+	public getProxyLogPath(): string {
+		const configured = expandPath(
+			String(
+				vscode.workspace.getConfiguration().get("coder.proxyLogDirectory") ??
+					"",
+			).trim(),
+		);
+		return configured || this.getLogPath();
+	}
+
 	/**
 	 * Get the path to the user's settings.json file.
 	 *

src/remote/remote.ts

@@ -46,7 +46,6 @@ import { OAuthSessionManager } from "../oauth/sessionManager";
 import {
 	AuthorityPrefix,
 	escapeCommandArg,
-	expandPath,
 	parseRemoteAuthority,
 } from "../util";
 import { vscodeProposed } from "../vscodeProposed";
@@ -717,21 +716,16 @@ export class Remote {
 
 	/**
 	 * Return the --log-dir argument value for the ProxyCommand. It may be an
-	 * empty string if the setting is not set or the cli does not support it.
+	 * empty string if the CLI does not support it. Falls back to extension
+	 * storage when the user setting is not configured.
 	 *
 	 * Value defined in the "coder.sshFlags" setting is not considered.
 	 */
 	private getLogDir(featureSet: FeatureSet): string {
 		if (!featureSet.proxyLogDirectory) {
 			return "";
 		}
-		// If the proxyLogDirectory is not set in the extension settings we don't send one.
-		return expandPath(
-			String(
-				vscode.workspace.getConfiguration().get("coder.proxyLogDirectory") ??
-					"",
-			).trim(),
-		);
+		return this.pathResolver.getProxyLogPath();
 	}
 
 	/**