refactor: remove dead code, fix duplication and indentation

- Remove unused getErrorHtml() (dead after proxy removal).
- Extract renderView() to deduplicate resolveWebviewView/refresh.
- Fix package.json indentation (extra nesting introduced in prior commit).

Author: ThomasK33

package.json

@@ -180,61 +180,62 @@
 				}
 			}
 		},
-			"viewsContainers": {
-				"activitybar": [
-					{
-						"id": "coder",
-						"title": "Coder Remote",
-						"icon": "media/shorthand-logo.svg"
-					},
-					{
-						"id": "coderTasks",
-						"title": "Coder Tasks",
-						"icon": "media/tasks-logo.svg"
-					}
-				],
-				"panel": [
-					{
-						"id": "coderChat",
-						"title": "Coder Chat",
-						"icon": "media/shorthand-logo.svg"
-					}
-				]
-			},
-			"views": {
-				"coder": [
-					{
-						"id": "myWorkspaces",
-						"name": "My Workspaces",
-						"visibility": "visible",
-						"icon": "media/logo-white.svg"
-					},
-					{
-						"id": "allWorkspaces",
-						"name": "All Workspaces",
-						"visibility": "visible",
-						"icon": "media/logo-white.svg",
-						"when": "coder.authenticated && coder.isOwner"
-					}
-				],
-				"coderTasks": [
-					{
-						"type": "webview",
-						"id": "coder.tasksPanel",
-						"name": "Coder Tasks",
-						"icon": "media/tasks-logo.svg",
-						"when": "coder.authenticated"
-					}
-				],
-				"coderChat": [
-					{
-						"type": "webview",
-						"id": "coder.chatPanel",
-						"name": "Coder Chat"
-					}
-				]
-			},
-			"viewsWelcome": [			{
+		"viewsContainers": {
+			"activitybar": [
+				{
+					"id": "coder",
+					"title": "Coder Remote",
+					"icon": "media/shorthand-logo.svg"
+				},
+				{
+					"id": "coderTasks",
+					"title": "Coder Tasks",
+					"icon": "media/tasks-logo.svg"
+				}
+			],
+			"panel": [
+				{
+					"id": "coderChat",
+					"title": "Coder Chat",
+					"icon": "media/shorthand-logo.svg"
+				}
+			]
+		},
+		"views": {
+			"coder": [
+				{
+					"id": "myWorkspaces",
+					"name": "My Workspaces",
+					"visibility": "visible",
+					"icon": "media/logo-white.svg"
+				},
+				{
+					"id": "allWorkspaces",
+					"name": "All Workspaces",
+					"visibility": "visible",
+					"icon": "media/logo-white.svg",
+					"when": "coder.authenticated && coder.isOwner"
+				}
+			],
+			"coderTasks": [
+				{
+					"type": "webview",
+					"id": "coder.tasksPanel",
+					"name": "Coder Tasks",
+					"icon": "media/tasks-logo.svg",
+					"when": "coder.authenticated"
+				}
+			],
+			"coderChat": [
+				{
+					"type": "webview",
+					"id": "coder.chatPanel",
+					"name": "Coder Chat"
+				}
+			]
+		},
+		"viewsWelcome": [
+			{
 				"view": "myWorkspaces",
 				"contents": "Coder is a platform that provisions remote development environments. \n[Login](command:coder.login)",
 				"when": "!coder.authenticated && coder.loaded"

src/webviews/chat/chatPanelProvider.ts

@@ -51,61 +51,43 @@ export class ChatPanelProvider
 		_token: vscode.CancellationToken,
 	): Promise<void> {
 		this.view = webviewView;
-
-		if (!this.agentId) {
-			webviewView.webview.html = this.getNoAgentHtml();
-			return;
-		}
-
-		const coderUrl = this.client.getHost();
-		if (!coderUrl) {
-			webviewView.webview.html = this.getNoAgentHtml();
-			return;
-		}
-
-		webviewView.webview.options = { enableScripts: true };
-
-		this.disposeInternals();
-
-		this.disposables.push(
-			webviewView.webview.onDidReceiveMessage((msg: unknown) => {
-				this.handleMessage(msg);
-			}),
-		);
-
-		const embedUrl = `${coderUrl}/agents/${this.agentId}/embed`;
-		webviewView.webview.html = this.getIframeHtml(embedUrl, coderUrl);
-
+		this.renderView();
 		webviewView.onDidDispose(() => this.disposeInternals());
 	}
 
 	public refresh(): void {
 		if (!this.view) {
 			return;
 		}
+		this.renderView();
+	}
+
+	private renderView(): void {
+		const webview = this.view!.webview;
 
 		if (!this.agentId) {
-			this.view.webview.html = this.getNoAgentHtml();
+			webview.html = this.getNoAgentHtml();
 			return;
 		}
 
 		const coderUrl = this.client.getHost();
 		if (!coderUrl) {
-			this.view.webview.html = this.getNoAgentHtml();
+			webview.html = this.getNoAgentHtml();
 			return;
 		}
 
 		this.disposeInternals();
 
+		webview.options = { enableScripts: true };
+
 		this.disposables.push(
-			this.view.webview.onDidReceiveMessage((msg: unknown) => {
+			webview.onDidReceiveMessage((msg: unknown) => {
 				this.handleMessage(msg);
 			}),
 		);
 
-		this.view.webview.options = { enableScripts: true };
 		const embedUrl = `${coderUrl}/agents/${this.agentId}/embed`;
-		this.view.webview.html = this.getIframeHtml(embedUrl, coderUrl);
+		webview.html = this.getIframeHtml(embedUrl, coderUrl);
 	}
 
 	private handleMessage(message: unknown): void {
@@ -217,15 +199,6 @@ text-align:center;}</style></head>
 <body><p>No active chat session. Open a chat from the Agents tab on your Coder deployment.</p></body></html>`;
 	}
 
-	private getErrorHtml(message: string): string {
-		return /* html */ `<!DOCTYPE html>
-<html lang="en"><head><meta charset="UTF-8">
-<style>body{display:flex;align-items:center;justify-content:center;
-height:100vh;margin:0;font-family:var(--vscode-font-family);
-color:var(--vscode-errorForeground,#f44);}</style></head>
-<body><p>${message}</p></body></html>`;
-	}
-
 	private disposeInternals(): void {
 		for (const d of this.disposables) {
 			d.dispose();