Reworked the version select code a little bit

Author: coder0107git

package.json

@@ -12,6 +12,8 @@
   },
   "dependencies": {
     "@jcubic/wayne": "~0.19.1",
+    "@octokit/openapi-types": "^27.0.0",
+    "@octokit/types": "^16.0.0",
     "@vite-pwa/astro": "^1.0.0",
     "@zenfs/archives": "^1.1.0",
     "@zenfs/core": "^2.0.0",
@@ -30,5 +32,5 @@
     "tinyexec": "^1.0.1",
     "vite": "^6.3.7"
   },
-  "packageManager": "pnpm@11.6.0+sha512.9a36518224080c6fe5165afdcfe79bfa118c29be703f3f462b1e32efe1e98e47e8750b148e08286250aad4113cc7993ca413c4e2cd447752708c2ee5751bc95f"
+  "packageManager": "pnpm@11.9.0+sha512.bd682d5d03fe525ef7c9fd6780c6884d1e756ac4c9c9fe00c538782824310dcf90e3ddc4f53835f06dfaebd5085e41855e0bcbb3b60de2ac5bbab89e5036f03b"
 }

pnpm-lock.yaml

@@ -0,0 +1,85 @@
+import type { paths as $paths } from "@octokit/openapi-types";
+
+type ReleaseInfo = $paths["/repos/{owner}/{repo}/releases"]["get"];
+type PotentialReleasesResponses = ReleaseInfo["responses"];
+
+
+/** @license Apache-2.0 */
+interface TypedHeaders<HeadersRecord extends Record<string, string>> extends Headers {
+    append<Header extends keyof HeadersRecord>(name: Header, value: HeadersRecord[Header]): void;
+    delete(name: keyof HeadersRecord): void;
+    
+    get<
+        Header extends ((string & {}) | keyof HeadersRecord)
+    >(name: Header): 
+        Header extends keyof HeadersRecord 
+            ? HeadersRecord[Header] 
+            : null;
+    has(name: keyof HeadersRecord): name is keyof HeadersRecord;
+    set<Header extends keyof HeadersRecord>(name: Header, value: HeadersRecord[Header]): void;
+    
+    forEach(
+        callbackfn: <Header extends Exclude<keyof HeadersRecord, symbol | number>>(
+            value: HeadersRecord[Header], 
+            key: Header, 
+            parent: TypedHeaders<HeadersRecord>,
+        ) => void, 
+        thisArg?: any,
+    ): void;
+
+
+    [Symbol.iterator]<Keys extends keyof HeadersRecord>(): HeadersIterator<[Keys, HeadersRecord[Keys]]>;
+    entries<Keys extends keyof HeadersRecord>(): HeadersIterator<[Keys, HeadersRecord[Keys]]>;
+    
+    keys(): HeadersIterator<Exclude<keyof HeadersRecord, number | symbol>>;
+    values(): HeadersIterator<HeadersRecord[keyof HeadersRecord]>;
+}
+
+
+/** @license Apache-2.0 */
+interface TypedResponse<
+    StatusCode extends Response["status"],
+    CustomHeaders extends TypedHeaders<Record<string, string>> = TypedHeaders<Record<string, string>>,
+    Url extends Response["url"] = Response["url"],
+> extends Response {
+    readonly status: StatusCode;
+    readonly ok: StatusCode extends 200 | 201 | 202 | 204 | 205 ? true : false;
+
+    readonly url: Url;
+    readonly headers: CustomHeaders;
+
+    clone(): this;    
+}
+
+interface TypedJsonResponse<
+    StatusCode extends Response["status"],
+    Data extends unknown,
+    CustomHeaders extends TypedHeaders<Record<string, string>> = TypedHeaders<Record<string, string>>,
+    Url extends Response["url"] = Response["url"],
+> extends TypedResponse<StatusCode, CustomHeaders, Url> {
+    json(): Promise<Data>;
+}
+
+
+
+import type { ResponseHeaders as $ResponseHeaders } from "@octokit/types";
+
+type CleanGithubResponseHeaders = {
+    [Header in keyof $ResponseHeaders as string extends Header ? never : Header]: string;
+};
+
+
+
+export type ReleasesResponse<
+    StatusCode extends keyof PotentialReleasesResponses = keyof PotentialReleasesResponses,
+    Content extends PotentialReleasesResponses[StatusCode]["content"] = PotentialReleasesResponses[StatusCode]["content"]
+> = keyof Content extends "application/json"
+    ? TypedJsonResponse<
+        StatusCode,
+        Content["application/json"],
+        TypedHeaders<CleanGithubResponseHeaders>
+    >
+    : TypedResponse<
+        StatusCode,
+        TypedHeaders<CleanGithubResponseHeaders>
+    >;

src/lib/github-releases-api.ts

@@ -51,6 +51,7 @@ if ("serviceWorker" in navigator) {
 }
 
 
+
 type VersionInfo = [
     string, 
     {
@@ -59,29 +60,53 @@ type VersionInfo = [
     }
 ];
 
-type ReleasesAPI = {
-    assets: [{ 
-        name: string; 
-        browser_download_url: string 
-    }];
-    name: string;
-    tag_name: string;
-};
-
 declare global {
     interface Window {
         versionInfoMap: Map<VersionInfo[0], VersionInfo[1]>
     }
 }
 
+
+import type { ReleasesResponse } from "./github-releases-api.ts";
+
+const NULL = Symbol(`safePromise: null`);
+async function safePromise<P extends Promise<unknown>>(promise: P): Promise<[Awaited<P>, typeof NULL] | [typeof NULL, any]> {
+    try {
+        return [await promise, NULL];
+    } catch (e) {
+        return [NULL, e];
+    }
+}
+
+
 async function populateVersionPicker() {
-    const releases: ReleasesAPI[] = await fetch(
+    const [response, responseError] = await safePromise(
+        fetch(
             "https://api.github.com/repos/jindrapetrik/jpexs-decompiler/releases?per_page=20"
-        )
-        .then((res) => res.json())
-        .catch(() => alert("Failed to fetch FFDEC versions"));
+        ) as Promise<ReleasesResponse>
+    );
+
+    if(responseError !== NULL || response === NULL || !response.ok) {
+        alert("Failed to fetch FFDEC versions");
+        console.error("Error:", responseError, "Response:", response);
 
-    const versionInfo: VersionInfo[] = releases.map(release => {
+        return;
+    }
+
+
+    const [releasesJson, jsonError] = await safePromise(
+        (response as ReleasesResponse<200>).json()
+    );
+
+    if(jsonError !== NULL || releasesJson === NULL) {
+        alert("Failed to parse GitHub releases API response as JSON.")
+        console.error("Error:", jsonError, "JSON:", releasesJson);
+
+        return;
+    }
+
+
+    const versionInfo: VersionInfo[] = releasesJson.map(release => {
         const { name, tag_name } = release;
         const downloadUrl = release.assets
             // Get only the universal zip. Technically "lib" is in the java doc 
@@ -91,7 +116,7 @@ async function populateVersionPicker() {
             .at(0)!;
 
         return [
-            name,
+            name!,
             {
                 url: downloadUrl,
                 slug: tag_name,
@@ -102,13 +127,14 @@ async function populateVersionPicker() {
 
 
     const versionSelect = document.querySelector("select")!;
+    const versionSelectOptions: HTMLOptionElement[] = [];
 
-    versionSelect.append(...versionInfo.map(release => {
-        const [name] = release;
-        const elem = document.createElement("option");
+    for (const [name] of versionInfo) {
+        const option = document.createElement("option");
+        option.textContent = name;
 
-        elem.innerText = name;
+        versionSelectOptions.push(option);
+    }
 
-        return elem;
-    }));
+    versionSelect.append(...versionSelectOptions);
 }