Fix lobby room list scrolling#259
Merged
Merged
Conversation
Release user-scoped solve history preview
Constrain the lobby flex hierarchy to the viewport so the existing room list overflow can scroll. Add a full-stack browser regression for short viewports.
coder13
marked this pull request as ready for review
July 18, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
The room list declared
overflow-y: auto, but flex and Grid ancestors remained content-sized. The room panel therefore grew beyond the viewport instead of giving the list a bounded scroll area; global page overflow then clipped the remaining rooms.User impact
Users can scroll through all public and private rooms again, including in short and mobile-sized viewports.
Validation
yarn workspace letscube-client lint(passes; existing warnings only)yarn workspace letscube-client test:ci --runInBand(97/97)yarn workspace letscube-client buildyarn cypress:run --spec cypress/e2e/local_stack.cy.js(11/11)git diff --check