Fix send_rich_message_draft business_connection_id TypeError#2
Closed
ranjitsingha wants to merge 1 commit into
Closed
Conversation
AsyncTeleBot/TeleBot.send_rich_message_draft forward business_connection_id to the api helpers, but neither send_rich_message_draft helper accepts it, so every call raises TypeError. Add the parameter to both the async and sync helpers and include it in the payload, mirroring send_rich_message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncTeleBot.send_rich_message_draft(and the syncTeleBotequivalent) forwardbusiness_connection_idto the api helpers:but neither
send_rich_message_drafthelper (asyncio_helper/apihelper) accepts abusiness_connection_idparameter, so every call fails with:Minimal repro (async):
This adds
business_connection_idto both the async and sync helpers and includes it in the payload when set, mirroring howsend_rich_messagealready threads it. Same family as the earliermessage_thread_idmismatch.Targeting
botapi101so it folds into the Bot API 10.1 rich-message work (eternnoir#2602). Verified the draft streams correctly once the helper accepts the kwarg.