fix: address CI failures and review feedback

- Add apt-get update before installs in CI workflow
- Suppress SC2317 on nested adapter functions in bin/gtr
- Replace SC2015 pattern with if-statement in lib/copy.sh
- Pre-compute AppleScript cmd line to avoid set -e abort in heredoc
- Add git identity config in test setup for CI environments
- Fix misleading test description for special char replacement

Author: helizaga

.github/workflows/lint.yml

@@ -14,7 +14,7 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Install ShellCheck
-        run: sudo apt-get install -y shellcheck
+        run: sudo apt-get update && sudo apt-get install -y shellcheck
 
       - name: Run ShellCheck
         run: |
@@ -27,7 +27,7 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Install BATS
-        run: sudo apt-get install -y bats
+        run: sudo apt-get update && sudo apt-get install -y bats
 
       - name: Run tests
         run: bats tests/

bin/gtr

@@ -69,10 +69,12 @@ ai_start() {
 # Standard AI adapter builder — used by adapter files that follow the common pattern
 # Sets globals then call this: _AI_CMD, _AI_ERR_MSG, _AI_INFO_LINES (array)
 _ai_define_standard() {
+  # shellcheck disable=SC2317 # Functions are called indirectly via adapter dispatch
   ai_can_start() {
     command -v "$_AI_CMD" >/dev/null 2>&1
   }
 
+  # shellcheck disable=SC2317
   ai_start() {
     local path="$1"; shift
     if ! ai_can_start; then
@@ -94,10 +96,12 @@ _ai_define_standard() {
 # Standard editor adapter builder — used by adapter files that follow the common pattern
 # Sets globals then call this: _EDITOR_CMD, _EDITOR_ERR_MSG, _EDITOR_WORKSPACE (optional, 0 or 1)
 _editor_define_standard() {
+  # shellcheck disable=SC2317 # Functions are called indirectly via adapter dispatch
   editor_can_open() {
     command -v "$_EDITOR_CMD" >/dev/null 2>&1
   }
 
+  # shellcheck disable=SC2317
   editor_open() {
     local path="$1"
     local workspace="${2:-}"
@@ -116,10 +120,12 @@ _editor_define_standard() {
 # Terminal editor adapter builder — for editors that run in the current terminal
 # Sets globals then call this: _EDITOR_CMD, _EDITOR_ERR_MSG, _EDITOR_BACKGROUND (optional, 0 or 1)
 _editor_define_terminal() {
+  # shellcheck disable=SC2317 # Functions are called indirectly via adapter dispatch
   editor_can_open() {
     command -v "$_EDITOR_CMD" >/dev/null 2>&1
   }
 
+  # shellcheck disable=SC2317
   editor_open() {
     local path="$1"
     if ! editor_can_open; then

lib/copy.sh

@@ -299,7 +299,9 @@ copy_directories() {
                     cd "$exclude_old_pwd" || true
 
                     # Log only if we actually removed something
-                    [ "$removed_any" -eq 1 ] && log_info "Excluded subdirectory $exclude_pattern" || true
+                    if [ "$removed_any" -eq 1 ]; then
+                      log_info "Excluded subdirectory $exclude_pattern"
+                    fi
                     ;;
                 esac
                 ;;

lib/platform.sh

@@ -96,6 +96,12 @@ spawn_terminal_in() {
       safe_title=$(_escape_applescript "$title")
       safe_cmd=$(_escape_applescript "$cmd")
 
+      # Pre-compute optional AppleScript write-text line (avoids set -e abort in heredoc)
+      local iterm_cmd_line=""
+      if [ -n "$safe_cmd" ]; then
+        iterm_cmd_line="write text \"$safe_cmd\""
+      fi
+
       # Try iTerm2 first, then Terminal.app
       if osascript -e 'tell application "System Events" to get name of first application process whose frontmost is true' 2>/dev/null | grep -q "iTerm"; then
         osascript <<-EOF 2>/dev/null || true
@@ -105,7 +111,7 @@ spawn_terminal_in() {
 							tell current session
 								write text "cd \"$safe_path\""
 								set name to "$safe_title"
-								$([ -n "$safe_cmd" ] && echo "write text \"$safe_cmd\"")
+								$iterm_cmd_line
 							end tell
 						end tell
 					end tell

tests/resolve_base_dir.bats

@@ -7,6 +7,8 @@ setup() {
   # Create a temporary git repo for testing
   TEST_REPO=$(mktemp -d)
   git -C "$TEST_REPO" init --quiet
+  git -C "$TEST_REPO" config user.name "Test User"
+  git -C "$TEST_REPO" config user.email "test@example.com"
   git -C "$TEST_REPO" commit --allow-empty -m "init" --quiet
 }
 

tests/sanitize_branch_name.bats

@@ -40,7 +40,7 @@ setup() {
   [ "$result" = "trailing-slash" ]
 }
 
-@test "multiple special chars produce single hyphens" {
+@test "multiple special chars are each replaced" {
   result=$(sanitize_branch_name "a//b")
   [ "$result" = "a--b" ]
 }