Skip to content

perf(copy): limit find depth for simple directory patterns #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
helizaga merged 2 commits into from
Feb 18, 2026
+7 −2
Merged

perf(copy): limit find depth for simple directory patterns #130

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86901f3
perf(copy): limit find depth for simple directory patterns
akirasosa Feb 18, 2026
d7ecd41
fix: add recursive fallback and set -e guards for find in copy_direct…
helizaga Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/copy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,10 +331,11 @@ copy_directories() {
# Find directories matching the pattern
# Use -path for patterns with slashes (e.g., vendor/bundle), -name for basenames
# Note: case inside $() inside heredocs breaks Bash 3.2, so compute first
# Use -maxdepth 1 for simple basenames to avoid scanning entire repo (e.g., node_modules)
local find_results
case "$pattern" in
*/*) find_results=$(find . -type d -path "./$pattern" 2>/dev/null) ;;
*) find_results=$(find . -type d -name "$pattern" 2>/dev/null) ;;
*) find_results=$(find . -maxdepth 1 -type d -name "$pattern" 2>/dev/null) ;;
Comment thread
helizaga marked this conversation as resolved.
Outdated
esac
Comment thread
helizaga marked this conversation as resolved.

while IFS= read -r dir_path; do
Expand Down